Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: update isElementPresent usages #20112

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented Jul 20, 2023

Explanation

The isElementPresent method returns a boolean, this boolean can be used in an assertion to verify the existence of an element

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PeterYinusa PeterYinusa self-assigned this Jul 20, 2023
@PeterYinusa PeterYinusa changed the title update isElementPresent usages E2E: update isElementPresent usages Jul 20, 2023
@PeterYinusa PeterYinusa marked this pull request as ready for review July 20, 2023 11:49
@PeterYinusa PeterYinusa requested a review from a team as a code owner July 20, 2023 11:49
@metamaskbot
Copy link
Collaborator

Builds ready [1a3057a]
Page Load Metrics (1738 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1002501573919
domContentLoaded15252026173814469
load15262026173814469
domInteractive15252026173814469
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #20112 (1a3057a) into develop (26225aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20112   +/-   ##
========================================
  Coverage    69.36%   69.36%           
========================================
  Files          986      986           
  Lines        37279    37279           
  Branches     10010    10010           
========================================
  Hits         25857    25857           
  Misses       11422    11422           

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PeterYinusa PeterYinusa merged commit 4422ce6 into develop Jul 20, 2023
@PeterYinusa PeterYinusa deleted the improve-isElementPresent-usage branch July 20, 2023 14:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 20, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants