-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E: update isElementPresent usages #20112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
PeterYinusa
changed the title
update isElementPresent usages
E2E: update isElementPresent usages
Jul 20, 2023
Builds ready [1a3057a]
Page Load Metrics (1738 ± 69 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #20112 +/- ##
========================================
Coverage 69.36% 69.36%
========================================
Files 986 986
Lines 37279 37279
Branches 10010 10010
========================================
Hits 25857 25857
Misses 11422 11422 |
Gudahtt
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
DDDDDanica
approved these changes
Jul 20, 2023
metamaskbot
added
the
release-10.36.0
Issue or pull request that will be included in release 10.36.0
label
Jul 20, 2023
Gudahtt
added
release-11.1.0
Issue or pull request that will be included in release 11.1.0
and removed
release-10.36.0
Issue or pull request that will be included in release 10.36.0
labels
Sep 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.1.0
Issue or pull request that will be included in release 11.1.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
isElementPresent
method returns a boolean, this boolean can be used in an assertion to verify the existence of an elementScreenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.