Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added back trackEvents to whats-new-popup #20110

Merged

Conversation

albertolive
Copy link
Contributor

Explanation

In the ui/components/app/whats-new-popup/whats-new-popup.js we removed the track events because we were waiting to use the Segments-Schema. We're now all of them in there so we're adding back.

https://github.com/Consensys/segment-schema/pull/83

AC:

  • The two events that we removed are back in this component.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@albertolive albertolive marked this pull request as ready for review July 20, 2023 13:03
@albertolive albertolive requested a review from a team as a code owner July 20, 2023 13:03
@metamaskbot
Copy link
Collaborator

Builds ready [0fe345f]
Page Load Metrics (1584 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint108168128168
domContentLoaded1453179615848842
load1453179615848842
domInteractive1453179615848842
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #20110 (0fe345f) into develop (26225aa) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff            @@
##           develop   #20110   +/-   ##
========================================
  Coverage    69.36%   69.36%           
========================================
  Files          986      986           
  Lines        37279    37283    +4     
  Branches     10010    10010           
========================================
+ Hits         25857    25860    +3     
- Misses       11422    11423    +1     
Impacted Files Coverage Δ
.../components/app/whats-new-popup/whats-new-popup.js 21.54% <50.00%> (+0.44%) ⬆️
shared/constants/metametrics.ts 100.00% <100.00%> (ø)

@albertolive albertolive merged commit e8deec2 into develop Jul 20, 2023
@albertolive albertolive deleted the feature/MMI-3314-add-back-trackevents-in-whatsnewpopup branch July 20, 2023 14:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 20, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants