Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate component to TS: Input #20094

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

dhruvv173
Copy link
Contributor

@dhruvv173 dhruvv173 commented Jul 19, 2023

Explanation

Screenshots/Screencaps

Before

before.mp4

After

after.mp4

No instances of INPUT_TYPES

Screenshot 2023-07-24 at 3 36 57 PM

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173 dhruvv173 mentioned this pull request Jul 19, 2023
8 tasks
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 19, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Really nice work 💯. I made some small adjustments and rebased from develop. Thanks for your contribution @dhruvv173

@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 24, 2023 22:38
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 24, 2023 22:38
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #20094 (a1352e9) into develop (02b8edc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #20094      +/-   ##
===========================================
- Coverage    69.45%   69.44%   -0.01%     
===========================================
  Files          986      985       -1     
  Lines        37290    37288       -2     
  Branches     10014    10015       +1     
===========================================
- Hits         25898    25894       -4     
- Misses       11392    11394       +2     
Files Changed Coverage Δ
ui/components/component-library/input/input.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 @dhruvv173

@garrettbear garrettbear merged commit 5693d19 into MetaMask:develop Jul 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
@dhruvv173 dhruvv173 deleted the fix/19122 branch July 25, 2023 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate components to TS: Input
3 participants