-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate component to TS: Input #20094
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
de4ef59
to
a1352e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Really nice work 💯. I made some small adjustments and rebased from develop
. Thanks for your contribution @dhruvv173
Codecov Report
@@ Coverage Diff @@
## develop #20094 +/- ##
===========================================
- Coverage 69.45% 69.44% -0.01%
===========================================
Files 986 985 -1
Lines 37290 37288 -2
Branches 10014 10015 +1
===========================================
- Hits 25898 25894 -4
- Misses 11392 11394 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation
Screenshots/Screencaps
Before
before.mp4
After
after.mp4
No instances of
INPUT_TYPES
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.