Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #18714: Replacing deprecated constants and components #20070

Merged

Conversation

dhruvv173
Copy link
Contributor

Explanation

ui/components/app/signature-request-original/signature-request-original-warning

Screenshots/Screencaps

After

image
image

unit test coverage
image

Manual Testing Steps

  • Check controls for SignatureRequestOriginalWarning on this branch

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner July 18, 2023 08:56
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173 dhruvv173 changed the title replacing deprecated constants and components Part of #18714: Replacing deprecated constants and components Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #20070 (bc45641) into develop (1277c62) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #20070      +/-   ##
===========================================
- Coverage    69.42%   69.42%   -0.01%     
===========================================
  Files          990      990              
  Lines        37418    37418              
  Branches     10039    10039              
===========================================
- Hits         25976    25974       -2     
- Misses       11442    11444       +2     
Impacted Files Coverage Δ
...inal-warning/signature-request-original-warning.js 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 19, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NidhiKJha NidhiKJha merged commit 821888e into MetaMask:develop Jul 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
@dhruvv173 dhruvv173 deleted the issue-rep-deprecated-constants branch July 19, 2023 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants