Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clipboard): Increase DEFAULT copy to clipboard time #20008

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

HowardBraham
Copy link
Contributor

#19948 only fixed a few parts of this problem

The larger problem is that the default timeout on useCopyToClipboard() was 3 seconds.

Other confirmed problem areas:

  • Copy private key to clipboard
  • Contact list
  • Token detection import tokens popup
  • Activity tab -> select a transaction -> then copy from the destination address

There are also likely to be a few more bugs that nobody has found yet. So this PR changes the default timeout from 3 seconds to 1 minute.

@HowardBraham HowardBraham requested a review from a team as a code owner July 13, 2023 19:23
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brad-decker
Copy link
Contributor

brad-decker commented Jul 13, 2023

Maybe i'm misunderstanding but why does it take longer than 3 seconds to copy something to the clipboard?

edit
Is it that we're replacing the copied value for security purposes after the delay?

@metamaskbot
Copy link
Collaborator

Builds ready [62ed16d]
Page Load Metrics (1715 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint119182145178
domContentLoaded14651945171411656
load14651946171511756
domInteractive14651945171411656
Bundle size diffs
  • background: 0 bytes
  • ui: -2 bytes
  • common: 0 bytes

@HowardBraham
Copy link
Contributor Author

Is it that we're replacing the copied value for security purposes after the delay?

Yes, it's clearing the clipboard after 3 seconds.
(does not clear if you have closed the Extension popup or tab)

@HowardBraham HowardBraham merged commit 3ef2faf into develop Jul 13, 2023
@HowardBraham HowardBraham deleted the fix/increase-default-clipboard-time branch July 13, 2023 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 13, 2023
@plasmacorral
Copy link
Contributor

Will address #19548

@plasmacorral plasmacorral linked an issue Jul 18, 2023 that may be closed by this pull request
@Gudahtt Gudahtt added release-10.34.2 Issue or pull request that will be included in release 10.34.2 and removed release-10.35.0 Issue or pull request that will be included in release 10.35.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.34.2 Issue or pull request that will be included in release 10.34.2 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Copying addresses to clipboard is not working
8 participants