-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASK] Unblock personal_sign
for snaps
#19998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [bd70d58]
Page Load Metrics (1594 ± 53 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #19998 +/- ##
========================================
Coverage 69.38% 69.38%
========================================
Files 987 987
Lines 37267 37271 +4
Branches 10008 10010 +2
========================================
+ Hits 25854 25857 +3
- Misses 11413 11414 +1
|
Mrtenz
approved these changes
Jul 21, 2023
GuillaumeRx
approved these changes
Jul 21, 2023
metamaskbot
added
the
release-10.36.0
Issue or pull request that will be included in release 10.36.0
label
Jul 21, 2023
danjm
pushed a commit
that referenced
this pull request
Aug 19, 2023
* Add snap legacy authorship header * Add legacy snap header to personal_sign * Disable SIWE for snaps * Add comment
Gudahtt
added
release-11.1.0
Issue or pull request that will be included in release 11.1.0
and removed
release-10.36.0
Issue or pull request that will be included in release 10.36.0
labels
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Add support for usage of
personal_sign
for snaps by using a legacy authorship header for this specific screen. Furthermore, SIWE is turned off for all snap requests.This needs work from the snaps monorepo to be feature complete.
Progresses MetaMask/snaps#1551