Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Unblock personal_sign for snaps #19998

Merged
merged 5 commits into from
Jul 21, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jul 13, 2023

Explanation

Add support for usage of personal_sign for snaps by using a legacy authorship header for this specific screen. Furthermore, SIWE is turned off for all snap requests.
Screenshot 2023-07-20 at 23 35 13

This needs work from the snaps monorepo to be feature complete.

Progresses MetaMask/snaps#1551

@FrederikBolding FrederikBolding marked this pull request as ready for review July 20, 2023 21:37
@FrederikBolding FrederikBolding requested review from a team as code owners July 20, 2023 21:37
@metamaskbot
Copy link
Collaborator

Builds ready [bd70d58]
Page Load Metrics (1594 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint111153132115
domContentLoaded14391816159411153
load14391816159411153
domInteractive14391816159411153
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 271 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #19998 (bd70d58) into develop (733391a) will increase coverage by 0.00%.
The diff coverage is 77.78%.

@@           Coverage Diff            @@
##           develop   #19998   +/-   ##
========================================
  Coverage    69.38%   69.38%           
========================================
  Files          987      987           
  Lines        37267    37271    +4     
  Branches     10008    10010    +2     
========================================
+ Hits         25854    25857    +3     
- Misses       11413    11414    +1     
Impacted Files Coverage Δ
...t-original/signature-request-original.component.js 59.79% <75.00%> (-0.21%) ⬇️
ui/pages/confirm-signature-request/index.js 63.08% <80.00%> (+1.17%) ⬆️

@FrederikBolding FrederikBolding merged commit ba001b5 into develop Jul 21, 2023
@FrederikBolding FrederikBolding deleted the fb/unblock-snaps-personal-sign branch July 21, 2023 09:28
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 21, 2023
danjm pushed a commit that referenced this pull request Aug 19, 2023
* Add snap legacy authorship header

* Add legacy snap header to personal_sign

* Disable SIWE for snaps

* Add comment
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flask release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants