-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Network Menu Search #19985
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
68dd473
to
621ab82
Compare
Builds ready [621ab82]
Page Load Metrics (1945 ± 127 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov Report
@@ Coverage Diff @@
## develop #19985 +/- ##
===========================================
+ Coverage 69.45% 69.46% +0.01%
===========================================
Files 984 984
Lines 37290 37309 +19
Branches 10012 10020 +8
===========================================
+ Hits 25899 25915 +16
- Misses 11391 11394 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functionality, both look good to me
866203e
to
1498a99
Compare
Builds ready [1498a99]
Page Load Metrics (1533 ± 29 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [0ba6023]
Page Load Metrics (1631 ± 44 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This looks good to me, thank you David! |
Explanation
Implements a Search box in the network menu
Screenshots/Screencaps
NetworkSearch.mov
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.