Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Network Menu Search #19985

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Implement Network Menu Search #19985

merged 4 commits into from
Jul 28, 2023

Conversation

darkwing
Copy link
Contributor

Explanation

Implements a Search box in the network menu

Screenshots/Screencaps

NetworkSearch.mov

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner July 12, 2023 21:20
@darkwing darkwing marked this pull request as draft July 12, 2023 21:20
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing marked this pull request as ready for review July 14, 2023 20:32
@darkwing darkwing changed the title WIP: Implement Network Menu Search Implement Network Menu Search Jul 14, 2023
@darkwing darkwing force-pushed the network-search branch 2 times, most recently from 68dd473 to 621ab82 Compare July 17, 2023 18:10
@metamaskbot
Copy link
Collaborator

Builds ready [621ab82]
Page Load Metrics (1945 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1092711884622
domContentLoaded142423901943263126
load142424141945265127
domInteractive142423901943263126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 808 bytes
  • common: 73 bytes

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #19985 (0ba6023) into develop (3e6f1c3) will increase coverage by 0.01%.
The diff coverage is 85.00%.

@@             Coverage Diff             @@
##           develop   #19985      +/-   ##
===========================================
+ Coverage    69.45%   69.46%   +0.01%     
===========================================
  Files          984      984              
  Lines        37290    37309      +19     
  Branches     10012    10020       +8     
===========================================
+ Hits         25899    25915      +16     
- Misses       11391    11394       +3     
Files Changed Coverage Δ
.../multichain/network-list-menu/network-list-menu.js 69.62% <83.33%> (+4.05%) ⬆️
.../multichain/network-list-item/network-list-item.js 97.14% <100.00%> (+0.08%) ⬆️

NidhiKJha
NidhiKJha previously approved these changes Jul 18, 2023
Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality, both look good to me

vthomas13
vthomas13 previously approved these changes Jul 18, 2023
@darkwing darkwing dismissed stale reviews from vthomas13 and NidhiKJha via 866203e July 18, 2023 22:21
@darkwing darkwing force-pushed the network-search branch 2 times, most recently from 866203e to 1498a99 Compare July 21, 2023 17:52
@metamaskbot
Copy link
Collaborator

Builds ready [1498a99]
Page Load Metrics (1533 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint105163130168
domContentLoaded1440163215336029
load1440163215336029
domInteractive1440163215336029
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 953 Bytes (0.01%)
  • common: 73 Bytes (0.00%)

garrettbear
garrettbear previously approved these changes Jul 24, 2023
NidhiKJha
NidhiKJha previously approved these changes Jul 25, 2023
@darkwing darkwing dismissed stale reviews from NidhiKJha and garrettbear via 0ba6023 July 25, 2023 15:15
@metamaskbot
Copy link
Collaborator

Builds ready [0ba6023]
Page Load Metrics (1631 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1211901462010
domContentLoaded1441182116319144
load1441182116319144
domInteractive1441182116319144
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 953 Bytes (0.01%)
  • common: 73 Bytes (0.00%)

@kevinghim kevinghim added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Jul 25, 2023
@SaraCheikh
Copy link

This looks good to me, thank you David!

@darkwing darkwing merged commit 57ca5d9 into develop Jul 28, 2023
@darkwing darkwing deleted the network-search branch July 28, 2023 16:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 28, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants