Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding experimental flag for blockaid #19819

Merged
merged 76 commits into from
Jul 20, 2023
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jun 29, 2023

Adding preference for enable blockaid security check:

Screenshot 2023-06-29 at 2 48 02 PM

@jpuri jpuri force-pushed the adding_blockaid_preference branch from 947bfde to 8e2a2af Compare July 4, 2023 09:03
@metamaskbot
Copy link
Collaborator

Builds ready [8e2a2af]
Page Load Metrics (1449 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint102133115105
domContentLoaded1377158414495225
load1377158414495225
domInteractive1377158414495225
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 0 bytes
  • common: 448 bytes

matthewwalsh0
matthewwalsh0 previously approved these changes Jul 6, 2023
brad-decker
brad-decker previously approved these changes Jul 7, 2023
Base automatically changed from integrate_ppom to develop July 12, 2023 14:20
@jpuri jpuri dismissed stale reviews from brad-decker and matthewwalsh0 July 12, 2023 14:20

The base branch was changed.

@jpuri jpuri requested a review from kumavis as a code owner July 12, 2023 14:20
@metamaskbot
Copy link
Collaborator

Builds ready [784d950]
Page Load Metrics (1679 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1093631535627
domContentLoaded15332013167912259
load15332013167912359
domInteractive15332013167812259
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 0 bytes
  • common: 448 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [30cbd77]
Page Load Metrics (1612 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1131961422210
domContentLoaded1487191616119445
load1487191616129445
domInteractive1487191616119445
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 0 bytes
  • common: 448 bytes

@jpuri jpuri mentioned this pull request Jul 19, 2023
8 tasks
@jpuri jpuri merged commit 6ce80fe into develop Jul 20, 2023
@jpuri jpuri deleted the adding_blockaid_preference branch July 20, 2023 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 20, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants