-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 18896 Replace deprecated Button component with new Button component #19559
Issue 18896 Replace deprecated Button component with new Button component #19559
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have submitted this PR for fixing one of the files for issue #18896 Thanks in advance! |
81dd0a3
to
ff26741
Compare
ea7027e
to
9374087
Compare
Hey @ujwalkumar1995, would you be able to update this PR I believe it is close so it would be great if we can get it merged |
Hey @georgewrmarshall |
f5b2606
to
cdaded3
Compare
Codecov Report
@@ Coverage Diff @@
## develop #19559 +/- ##
===========================================
- Coverage 68.67% 68.67% -0.01%
===========================================
Files 986 986
Lines 37862 37862
Branches 10135 10135
===========================================
- Hits 26001 25998 -3
- Misses 11861 11864 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution @ujwalkumar1995
4a365e5
cdaded3
to
4a365e5
Compare
Explanation
As part of this PR, I have replaced the depracated button component (ui/components/ui/button/button.component.js) with ui/components/component-library/button/button.js
UrlIcon
in favour of appropriateAvatar
#18718Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.