Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 18896 Replace deprecated Button component with new Button component #19559

Conversation

ujwalkumar1995
Copy link
Contributor

@ujwalkumar1995 ujwalkumar1995 commented Jun 11, 2023

Explanation

As part of this PR, I have replaced the depracated button component (ui/components/ui/button/button.component.js) with ui/components/component-library/button/button.js

Screenshots/Screencaps

Before

Screenshot 2023-06-13 at 5 08 21 PM

After

Screenshot 2023-06-13 at 5 08 43 PM

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@ujwalkumar1995 ujwalkumar1995 requested a review from a team as a code owner June 11, 2023 06:56
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ujwalkumar1995
Copy link
Contributor Author

Hey @georgewrmarshall

I have submitted this PR for fixing one of the files for issue #18896
I can see in the screenshot of before and after that there is some styling difference between the old and new buttons. I am not sure if this is intended as per some new design as I have not changed any styling as part of my changes.
Please let me know if this needs to be fixed and I will try to explore further.

Thanks in advance!

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 12, 2023
@georgewrmarshall georgewrmarshall self-requested a review June 12, 2023 19:27
@georgewrmarshall georgewrmarshall requested a review from dan437 June 14, 2023 00:22
@georgewrmarshall georgewrmarshall force-pushed the issue-18896-replace-deprecated-button-component branch from 81dd0a3 to ff26741 Compare June 19, 2023 19:38
@georgewrmarshall georgewrmarshall force-pushed the issue-18896-replace-deprecated-button-component branch from ea7027e to 9374087 Compare June 26, 2023 23:38
@georgewrmarshall
Copy link
Contributor

Hey @ujwalkumar1995, would you be able to update this PR I believe it is close so it would be great if we can get it merged

@ujwalkumar1995
Copy link
Contributor Author

Hey @georgewrmarshall
Sorry I completely forgot about this PR. I could not see any open review commits but I could see a merge conflict. I have resolved it. Please review.

@georgewrmarshall georgewrmarshall force-pushed the issue-18896-replace-deprecated-button-component branch from f5b2606 to cdaded3 Compare July 26, 2023 00:57
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #19559 (4a365e5) into develop (d3c9d4a) will decrease coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is 20.00%.

@@             Coverage Diff             @@
##           develop   #19559      +/-   ##
===========================================
- Coverage    68.67%   68.67%   -0.01%     
===========================================
  Files          986      986              
  Lines        37862    37862              
  Branches     10135    10135              
===========================================
- Hits         26001    25998       -3     
- Misses       11861    11864       +3     
Files Changed Coverage Δ
.../component-library/modal-content/modal-content.tsx 96.15% <ø> (ø)
ui/components/ui/url-icon/url-icon.js 100.00% <ø> (ø)
...swaps/dropdown-search-list/dropdown-search-list.js 75.68% <0.00%> (ø)
...pages/swaps/prepare-swap-page/prepare-swap-page.js 69.38% <0.00%> (ø)
ui/pages/swaps/import-token/import-token.js 75.00% <33.33%> (-12.50%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @ujwalkumar1995

garrettbear
garrettbear previously approved these changes Jul 26, 2023
@georgewrmarshall georgewrmarshall dismissed stale reviews from garrettbear and themself via 4a365e5 July 26, 2023 15:08
@georgewrmarshall georgewrmarshall force-pushed the issue-18896-replace-deprecated-button-component branch from cdaded3 to 4a365e5 Compare July 26, 2023 15:08
@georgewrmarshall georgewrmarshall self-requested a review July 26, 2023 15:09
@georgewrmarshall georgewrmarshall merged commit 4b2c777 into MetaMask:develop Jul 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
3 participants