Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-18714: Replaced deprecated constants with enum in confirmation-warning-modal.js #19477

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

surajgjadhav
Copy link
Contributor

@surajgjadhav surajgjadhav commented Jun 6, 2023

Explanation

Issue link: #18714
Replaced deprecated constants with enum in confirmation-warning-modal.js
Constants replaced with enum:
DISPLAY -> Display
FLEX_DIRECTION -> FlexDirection
FONT_WEIGHT -> FontWeight

Screenshots/Screencaps

confirmationWarningModal

Before

image

After

image

Manual Testing Steps

  • run yarn storybook
  • open localhost:6006 in browser
  • Search for confirmationWarningModal component

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@surajgjadhav surajgjadhav requested a review from a team as a code owner June 6, 2023 17:47
@surajgjadhav surajgjadhav requested a review from jpuri June 6, 2023 17:47
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #19477 (97a364c) into develop (b5b3f67) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19477      +/-   ##
===========================================
- Coverage    69.99%   69.99%   -0.01%     
===========================================
  Files          960      960              
  Lines        36804    36804              
  Branches      9454     9454              
===========================================
- Hits         25760    25758       -2     
- Misses       11044    11046       +2     
Impacted Files Coverage Δ
...mation-warning-modal/confirmation-warning-modal.js 50.00% <ø> (ø)

... and 2 files with indirect coverage changes

@georgewrmarshall georgewrmarshall requested review from georgewrmarshall and garrettbear and removed request for jpuri June 6, 2023 20:15
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 6, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @surajgjadhav

@surajgjadhav
Copy link
Contributor Author

Thanks @georgewrmarshall 😊 , will raise pr for other components as well 👍

@garrettbear garrettbear merged commit e7adf7a into MetaMask:develop Jun 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants