[MMI] adds segment events to Metametrics constants #19468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## develop #19468 +/- ##
===========================================
+ Coverage 69.47% 69.48% +0.01%
===========================================
Files 988 988
Lines 37313 37323 +10
Branches 9989 9990 +1
===========================================
+ Hits 25923 25933 +10
Misses 11390 11390
|
Builds ready [265faf0]
Page Load Metrics (1477 ± 37 ms)
Bundle size diffs
|
brad-decker
suggested changes
Jun 9, 2023
shared/constants/metametrics.ts
Outdated
Comment on lines
591
to
599
| UserClickedRefreshTokenLink = 'User clicked refresh token link', | ||
| ShowDeeplinkForSignature = 'Show deeplink for signature', | ||
| CustodianOnboarding = 'Custodian onboarding', | ||
| InstitutionalFeatureConnection = 'Institutional feature connection', | ||
| CustodianSelected = 'Custodian selected', | ||
| ConnectCustodian = 'Connect to custodian', | ||
| ConnectCustodianCancel = 'Connect to custodian cancel', | ||
| ConnectCustodianError = 'Connect to custodian error', | ||
| CustodialAccountsConnected = 'Custodial accounts connected', |
There was a problem hiding this comment.
Event names should all have title casing, and some of these don't make sense as actions. What does 'Custodian Onboarding' mean?. Has @worldlyjohn been asked to validate this schema?
There was a problem hiding this comment.
thanks @brad-decker . i have not, but here are the relevant links.
- these events must be defined in our MM-wide data schema. it's a new process that we just started implemented. MetaMask: Working with Analytics/Events (Slide Deck)
- Event Naming Conventions (Consensys Notion)
There was a problem hiding this comment.
Hey folks, thanks for the feedback, I'll update the event names to be Title Casing, they are the ones we have in use already, I'll also check the "Custodian Onboarding" one. My plan was to add/update them here in the extension and then add them in the Segment Schema repo.
Also I don't have access to the Event Naming Conventions (Consensys Notion) can you provide it to me?
Builds ready [442243c]
Page Load Metrics (1737 ± 57 ms)
Bundle size diffs
|
Builds ready [8d174af]
Page Load Metrics (1641 ± 66 ms)
Bundle size diffs
|
|
Hi @worldlyjohn can you give me write access to this repo: segment-schema |
|
hey @zone-live please request access via [email protected] |
Builds ready [f672619]
Page Load Metrics (1754 ± 76 ms)
Bundle size diffs
|
|
Hi @brad-decker I've updated this PR, with the work done in the segment-schema repo that has been approved by @worldlyjohn. |
brad-decker
approved these changes
Jul 18, 2023
albertolive
approved these changes
Jul 18, 2023
metamaskbot
added
the
release-10.36.0
Gudahtt
added
release-11.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MMI segment events enums to the Metametrics constants file to be in line with what MetaMask already has.
Segment-schema repo changes:
https://github.com/Consensys/segment-schema/pull/70
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.