-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating story for icon-border
#19467
Creating story for icon-border
#19467
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
hey @georgewrmarshall, Is it fine to open a PR for each component added to Storybook? I can include 2-3 components per PR if it makes it easier for you to review them. |
Codecov Report
@@ Coverage Diff @@
## develop #19467 +/- ##
===========================================
- Coverage 69.99% 69.99% -0.01%
===========================================
Files 960 960
Lines 36804 36804
Branches 9454 9454
===========================================
- Hits 25760 25758 -2
- Misses 11044 11046 +2 |
Hey @dhruvv173, one story per PR is good! If you would also like to contribute to our priority good first issue you could have a look at these: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dhruvv173, I realized this is a deprecated component. I've updated with a deprecation message. If you'd like to help us with some tech debt reduction I've listed some issues above. Thanks again for your contribution
87ddf33
to
4f2e774
Compare
Explanation
Created story for
icon-border
componentui/components/ui/icon-border
Screenshots/Screencaps
Before
After
after.mp4
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.