Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating story for asset-list #19450

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Conversation

dhruvv173
Copy link
Contributor

Explanation

  • Created story for asset-list component
  • ui/components/app/aasset-list

Screenshots/Screencaps

Before

Screenshot 2023-06-05 225337

After

image
image

after.mp4

covered jest test
image

Manual Testing Steps

  • Pull this branch
  • Run yarn storybook
  • Search for asset-list component

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner June 5, 2023 17:43
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvv173
Copy link
Contributor Author

Hey @georgewrmarshall, I was going through the codebase and noticed that there are several components for which stories have not been created. I have some experience in creating new stories, as I have previously created some during my PRs with your assistance. I have created one for the asset-list component. I hope it is acceptable that I took the initiative. I apologize in advance if it was not appropriate. Could you please review this PR?
Thanks!

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dhruvv173, thanks for taking the initiative. Yes, I absolutely think all components should have stories. Looks like you have one small linting issue yarn lint otherwise LGTM! Thanks for your contribution

ui/components/app/asset-list/asset-list.stories.js Outdated Show resolved Hide resolved
@dhruvv173
Copy link
Contributor Author

Hey @dhruvv173, thanks for taking the initiative. Yes, I absolutely think all components should have stories. Looks like you have one small linting issue yarn lint otherwise LGTM! Thanks for your contribution

Can I go ahead and try to make stories for the missing components?

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #19450 (7b28523) into develop (36de02f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19450      +/-   ##
===========================================
- Coverage    69.94%   69.93%   -0.01%     
===========================================
  Files          959      959              
  Lines        36822    36822              
  Branches      9455     9455              
===========================================
- Hits         25753    25751       -2     
- Misses       11069    11071       +2     

see 2 files with indirect coverage changes

@georgewrmarshall
Copy link
Contributor

Hey @dhruvv173, I think that would be ok. You could start with the ui/components/ui folder?

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 5, 2023
@dhruvv173
Copy link
Contributor Author

Hey @dhruvv173, I think that would be ok. You could start with the ui/components/ui folder?

Sure, will do!

@garrettbear garrettbear merged commit 2b95d7b into MetaMask:develop Jun 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
@dhruvv173 dhruvv173 deleted the Creating-story branch July 18, 2023 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants