-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating story for asset-list
#19450
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Hey @georgewrmarshall, I was going through the codebase and noticed that there are several components for which stories have not been created. I have some experience in creating new stories, as I have previously created some during my PRs with your assistance. I have created one for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dhruvv173, thanks for taking the initiative. Yes, I absolutely think all components should have stories. Looks like you have one small linting issue yarn lint
otherwise LGTM! Thanks for your contribution
Can I go ahead and try to make stories for the missing components? |
Codecov Report
@@ Coverage Diff @@
## develop #19450 +/- ##
===========================================
- Coverage 69.94% 69.93% -0.01%
===========================================
Files 959 959
Lines 36822 36822
Branches 9455 9455
===========================================
- Hits 25753 25751 -2
- Misses 11069 11071 +2 |
Hey @dhruvv173, I think that would be ok. You could start with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sure, will do! |
Explanation
asset-list
componentui/components/app/aasset-list
Screenshots/Screencaps
Before
After
after.mp4
covered
jest
testManual Testing Steps
yarn storybook
asset-list
componentPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.