-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #18714: Replacing deprecated constants in Avatar-Base
folder
#19408
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution @rohiiittttt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Need the build to pass. Then we can merge this Pr
Codecov Report
@@ Coverage Diff @@
## develop #19408 +/- ##
===========================================
- Coverage 69.94% 69.93% -0.01%
===========================================
Files 959 959
Lines 36822 36822
Branches 9455 9455
===========================================
- Hits 25753 25751 -2
- Misses 11069 11071 +2
|
Explanation
Replaced deprecated design system and storybook constants in the avatar-base
ui/components/component-library/avatar-base
Screenshots/Screencaps
Before
After
yarn jest
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.