-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component-Library storybook introduction fix #19359
Component-Library storybook introduction fix #19359
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
hey @georgewrmarshall, could you please review this PR? |
Codecov Report
@@ Coverage Diff @@
## develop #19359 +/- ##
===========================================
- Coverage 69.94% 69.93% -0.01%
===========================================
Files 959 959
Lines 36822 36822
Branches 9455 9455
===========================================
- Hits 25753 25751 -2
- Misses 11069 11071 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dhruvv173, this looks great. Can you please update the name COMPONENT-LIBRARY.stories.mdx
to README.stories.mdx
we still want a readme and I'm hoping it will still show up on GitHub ok so there is still readable documentation about the component-library without having to run storybook
I renamed the file but it does not show up on GitHub as a |
hey @georgewrmarshall, I did some research and found the fix to this. Now, it can be read on GitHub with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dhruvv173, checked out the branch looks good made a couple small updated wile I was there. Thanks for your contribution!
@@ -36,4 +36,4 @@ We are currently in the process of migrating all component-library components to | |||
|
|||
If internal folks have any questions please reach out the design system team via the internal slack channel [#metamask-design-system](https://consensys.slack.com/archives/C0354T27M5M) 💁 | |||
|
|||
[DS components figma file](https://www.figma.com/file/HKpPKij9V3TpsyMV1TpV7C/DS-Components?node-id=16%3A6) (internal) | |||
[DS components figma file](https://www.figma.com/file/HKpPKij9V3TpsyMV1TpV7C/DS-Components?node-id=16%3A6) (internal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh we made our Figma UI Kit publicly viewable so we can remove "(internal)"
[DS components figma file](https://www.figma.com/file/HKpPKij9V3TpsyMV1TpV7C/DS-Components?node-id=16%3A6) (internal) | |
[DS components figma file](https://www.figma.com/file/HKpPKij9V3TpsyMV1TpV7C/DS-Components?node-id=16%3A6) |
62d0a87
to
a357b8b
Compare
a357b8b
to
08d2482
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah missed the rename of the file. Nice work
Explanation
The Component-library introduction story is fixed and it maintains consistency with other introduction stories.
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pull this branch
run
yarn storybook
check
Introduction
inComponentLibrary
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.