-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added validTag string literal union #19258
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## develop #19258 +/- ##
===========================================
- Coverage 70.04% 70.03% -0.01%
===========================================
Files 962 962
Lines 36875 36875
Branches 9468 9468
===========================================
- Hits 25826 25824 -2
- Misses 11049 11051 +2
|
ef97f00
to
d0bb712
Compare
d0bb712
to
4f3c75a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @thebinij, this looks great! I've just added a deprecation message to ValidTag
. Thanks for your contribution
Explanation
ValidTag
enum to string literal union type for theText
component #18867Manual Testing Steps
No functional changes
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.