Part of #18714: Replacing deprecated constants in Icon folder

[dhruvv173]

Explanation

• This PR is a part of Replace deprecated constants with enums #18714
  Replaced deprecated design system and storybook constants in the Icon folder
  ui/components/component-library/icon

Screenshots/Screencaps

Before

before.1.mp4

After

after.mp4

Manual Testing Steps

jest tests

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Merging #19250 (741c35f) into develop (e1b1227) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19250      +/-   ##
===========================================
- Coverage    70.36%   70.36%   -0.01%     
===========================================
  Files          961      961              
  Lines        36850    36850              
  Branches      9589     9589              
===========================================
- Hits         25929    25927       -2     
- Misses       10921    10923       +2     

Impacted Files	Coverage Δ
ui/components/component-library/icon/icon.tsx	100.00% <ø> (ø)

... and 2 files with indirect coverage changes

[dhruvv173]

hi @georgewrmarshall , could you please review this PR when possible?
Thanks!

[garrettbear]

@dhruvv173 when you get a chance fix that conflict, otherwise this is looking good

[georgewrmarshall]

Hey @dhruvv173, this is looking good I did a search for the deprecated consts inside of the icon folder and got a result on FLEX_DIRECTION that needs updating. You will also need to resolve the conflict as @garrettbear mentioned

[dhruvv173]

Hey @dhruvv173, this is looking good I did a search for the deprecated consts inside of the icon folder and got a result on FLEX_DIRECTION that needs updating. You will also need to resolve the conflict as @garrettbear mentioned

@garrettbear @georgewrmarshall
I apologize for missing those constants. I will make the changes, resolve the conflict and resubmit.

[dhruvv173]

hey @garrettbear @georgewrmarshall
Apologies for the mistakes, you guys have been very polite while pointing them out and suggesting changes. I have made the requested changes, could you guys please review it?
Thanks!

[georgewrmarshall]

LGTM! Thanks for your contribution @dhruvv173!