Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Text Docs not rendering issue in Storybook #19248

Merged

Conversation

dhruvdabhi101
Copy link
Contributor

@dhruvdabhi101 dhruvdabhi101 commented May 22, 2023

Explanation

Thanks for the pull request. Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes:

  • What is the current state of things and why does it need to change?

In the current state, for Text, some docs were not showing properly.

  • What is the solution your changes offer and how does it work?

My solution changes the story book IDs. Before, Storybook IDs which were mentioned in codebase were wrong. So I replaced those IDs with Proper IDs.

Are there any issues, Slack conversations, Zendesk issues, user stories, etc. reviewers should consult to understand this pull request better? For instance:

Screenshots/Screencaps

Before

Screenshot 2023-05-22 at 14 18 31
Screenshot 2023-05-22 at 14 18 36

After

Screenshot 2023-05-22 at 14 08 03
Screenshot 2023-05-22 at 14 08 09

Manual Testing Steps

How should reviewers and QA manually test your changes? For instance:

  • Open Storybook View by running yarn storybook
  • Go to the ComponentsLibrary > Text > Docs
  • Go to the Font Weight Section

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvdabhi101 dhruvdabhi101 requested a review from a team as a code owner May 22, 2023 09:02
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dhruvdabhi101
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #19248 (662d476) into develop (9d38e53) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19248      +/-   ##
===========================================
- Coverage    70.30%   70.30%   -0.01%     
===========================================
  Files          960      960              
  Lines        36689    36689              
  Branches      9543     9543              
===========================================
- Hits         25793    25791       -2     
- Misses       10896    10898       +2     

see 2 files with indirect coverage changes

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 23, 2023
@georgewrmarshall georgewrmarshall requested review from georgewrmarshall and garrettbear and removed request for FrederikBolding May 23, 2023 19:54
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @dhruvdabhi101!

@garrettbear garrettbear merged commit 26bd689 into MetaMask:develop May 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Text stories rendering in MDX docs
3 participants