Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/storybook console cleanup #19244

Merged

Conversation

spiritanand
Copy link
Contributor

@spiritanand spiritanand commented May 21, 2023

Explanation

Fixes #16492

This PR fixes an issue where the networkList was not defined in any of the combineReducers calls, causing an error when spreading out ...testData. To resolve this, I refactored the networkList out of testData and updated the relevant code.

Changes Made:

  • Moved the networkList from testData to its own const.
  • Updated the imports and calls to include the networkList where necessary.
  • Verified that the application works correctly after the refactoring.

Screenshots/Screencaps

Before

image

After

image

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be required.

@spiritanand spiritanand requested a review from a team as a code owner May 21, 2023 10:30
@spiritanand spiritanand requested a review from cryptotavares May 21, 2023 10:30
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #19244 (4c56312) into develop (9d38e53) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19244      +/-   ##
===========================================
- Coverage    70.30%   70.30%   -0.01%     
===========================================
  Files          960      960              
  Lines        36689    36689              
  Branches      9543     9543              
===========================================
- Hits         25793    25791       -2     
- Misses       10896    10898       +2     

see 2 files with indirect coverage changes

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 22, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution

  • This PR only updates storybook files so it shouldn't effect the code coverage can be merged with current indirect coverage changes

@garrettbear garrettbear merged commit 20fe6fc into MetaMask:develop Jun 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
@spiritanand spiritanand deleted the fix/storybook-console-cleanup branch June 3, 2023 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧹 Storybook house keeping clean up console
3 participants