Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving RESIZE constant to textarea component folder #19240

Merged
merged 2 commits into from
May 23, 2023

Conversation

dhruvv173
Copy link
Contributor

Explanation

I also replaced the deprecated BLOCK_SIZES constant with BlockSize enum

To assist the reviewers in verifying that no visual changes have occurred after implementing the changes, I have attached the before and after screenshots below.

Screenshots/Screencaps

Before

image
image

After

image
image

Manual Testing Steps

yarn jest ui/components/ui/textarea passed 8 tests

image

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@dhruvv173 dhruvv173 requested a review from a team as a code owner May 20, 2023 09:21
@dhruvv173 dhruvv173 requested a review from brad-decker May 20, 2023 09:21
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #19240 (c427293) into develop (9d38e53) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #19240      +/-   ##
===========================================
- Coverage    70.30%   70.30%   -0.01%     
===========================================
  Files          960      961       +1     
  Lines        36689    36689              
  Branches      9543     9543              
===========================================
- Hits         25793    25791       -2     
- Misses       10896    10898       +2     
Impacted Files Coverage Δ
ui/components/ui/textarea/textarea.js 75.00% <ø> (ø)
ui/helpers/constants/design-system.ts 100.00% <ø> (ø)
ui/components/ui/textarea/textarea.constants.js 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@dhruvv173
Copy link
Contributor Author

hey @georgewrmarshall, could you please review this?
Thanks!

@georgewrmarshall georgewrmarshall self-requested a review May 20, 2023 21:06
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 20, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work thanks for your contribution @dhruvv173 🙏

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NidhiKJha NidhiKJha merged commit 49b8dcb into MetaMask:develop May 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2023
@dhruvv173 dhruvv173 deleted the Migrating-const-to-enum branch July 25, 2023 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move RESIZE constant to textarea component folder
3 participants