Part of #17670: Replace Typography with Text component in beta-header/index.js #18964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Hey @georgewrmarshall @NidhiKJha |
Comment on lines
38
to
39
| marginTop={0} | ||
| marginBottom={0} |
There was a problem hiding this comment.
The Text component doesn't have any default margins so you could remove these
Suggested change
| marginTop={0} | |
| marginBottom={0} |
There was a problem hiding this comment.
I have made the suggested changes.
Please review the commit, thanks!
DDDDDanica
reviewed
May 3, 2023
DDDDDanica
approved these changes
May 3, 2023
NidhiKJha
approved these changes
May 3, 2023
dhruvv173
deleted the
Part-of-#17670-Replace-Typography-with-Text-component
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR partially fixes #17670
made changes to the
beta-header/index.jscomponentui/components/app/beta-header/index.js
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.