-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #17670: Replace Typography with Text component in cancel-speedup-popover.js #18948
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
hey @NidhiKJha I created a new PR for this fix, this passes all the tests, please review it when possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution
Hey @dhruvv173 thanks for contributing, it looks good !
Thank you ! |
hey @DDDDDanica I couldnt attach before/after screenshots as the story file does not exist on storybook |
Explanation
Partially fixes #17670
Made changes by replacing the Typography component with Text component in the
cancel-speedup-popover.js
fileui/components/app/cancel-speedup-popover/cancel-speedup-popover.js
Couldnt attach the screenshot as the file wasnt found on storybook
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.