-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update knobs to control: MetamaskTemplateRenderer #18677
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good looks like there is a linting issue that needs to be fixed
export const WithInvalidElement = () => ( | ||
<MetaMaskTemplateRenderer | ||
sections={object('sections', [ | ||
{ | ||
...SECTIONS, | ||
key: 'safe-tree', | ||
}, | ||
{ | ||
element: 'Unsafe', | ||
key: 'unsafe-tree', | ||
children: | ||
'I should be displayed, but I wont be due to unsafe component', | ||
}, | ||
])} | ||
/> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested to @dj-pundir to remove this story as it was display an error intentionally but I don't think it adds much value in storybook
Done the linting. Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯 Thanks for your contribution!
Explanation
The knobs are deprecated so its in continuity with other tasks to change the knobs with controls. Following are changes to the component
metamask-template-renderer.stories.js
WithInvalidElement
story altogetherFixes: #18498
Screenshots/Screencaps
Here is
Before
After
Manual Testing Steps
yarn storybook
Pre-merge author checklist
Pre-merge reviewer checklist