-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #17670: Replace Typography with Text component in RecoveryPhraseReminder #18639
Merged
DDDDDanica
merged 8 commits into
MetaMask:develop
from
kremalicious:feature/17670-recovery-phrase-reminder
Apr 27, 2023
Merged
Part of #17670: Replace Typography with Text component in RecoveryPhraseReminder #18639
DDDDDanica
merged 8 commits into
MetaMask:develop
from
kremalicious:feature/17670-recovery-phrase-reminder
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
added
the
team-design-system
All issues relating to design system in Extension
label
Apr 19, 2023
DDDDDanica
reviewed
Apr 25, 2023
ui/components/app/recovery-phrase-reminder/recovery-phrase-reminder.js
Outdated
Show resolved
Hide resolved
DDDDDanica
reviewed
Apr 25, 2023
ui/components/app/recovery-phrase-reminder/recovery-phrase-reminder.js
Outdated
Show resolved
Hide resolved
DDDDDanica
approved these changes
Apr 27, 2023
brad-decker
approved these changes
Apr 27, 2023
Thanks for the contribution @kremalicious -- I'm updating your branch and seeing if we can get the build process passing, if it doesn't pass i'll investigate the issue and report here. |
pedronfigueiredo
approved these changes
Apr 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17670.
Switch
Typography
components withText
component within theRecoveryPhraseReminder
. Additionally, created story for it. And switched some markup around so that all items in that popover use theText
component, so all line height and text treatment is now consistent among all items.Screenshots/Screencaps
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.