-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #17670: Replace Typography with Text component #18569
Conversation
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 1 out of 2 committers have signed the CLA.
|
I have read the CLA Document and I hereby sign the CLA |
Hey there @omraval18 your first commit (the one you authored locally, versus the one you made via github UI) is under a different username which is why the CLA is failing. If you want to resolve this you'd need to set your git user email to your github email and then rebase your PR on develop. The new commit that creates will be attributed to your github username. https://stackoverflow.com/questions/28141653/does-user-name-in-git-need-to-match-my-github-username |
@brad-decker thanks I'll look into it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation
Updating
<Typography/>
to<Text/>
inui/pages/swaps/smart-transaction-status/smart-transaction-status.js
Screenshots/Screencaps
Before
After
Manual Testing Steps
SmartTransactionStatusLabel
in the Side PanelPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.