Part of #17670: Replace Typography with Text component #17766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
georgewrmarshall
requested review from
georgewrmarshall
and removed request for
montelaidev
georgewrmarshall
requested changes
Feb 15, 2023
ui/components/app/confirm-page-container/confirm-page-container.component.js
Outdated
Show resolved
Hide resolved
ui/components/app/confirm-page-container/confirm-page-container.component.js
Outdated
Show resolved
Hide resolved
Co-authored-by: George Marshall <[email protected]>
…r.component.js Co-authored-by: George Marshall <[email protected]>
…r.component.js Co-authored-by: George Marshall <[email protected]>
| color={Color.textAlternative} | ||
| variant={TypographyVariant.H6} | ||
| fontWeight={FONT_WEIGHT.NORMAL} | ||
| variant={TextVariant.bodySm} |
There was a problem hiding this comment.
Ah oversight on my part we need to add html tags here so that some e2e tests pass. I've updated the description of the issue if you'd like to look.
Suggested change
| variant={TextVariant.bodySm} | |
| variant={TextVariant.bodySm} | |
| as="h6" |
georgewrmarshall
requested changes
Feb 15, 2023
| <Typography | ||
| variant={TypographyVariant.H7} | ||
| <Text | ||
| variant={TextVariant.bodySm} |
There was a problem hiding this comment.
Suggested change
| variant={TextVariant.bodySm} | |
| variant={TextVariant.bodySm} | |
| as="h6" |
| @@ -230,7 +230,7 @@ const ConfirmPageContainer = (props) => { | |||
| <ActionableMessage | |||
| message={ | |||
| isBuyableChain ? ( | |||
| <Typography variant={TypographyVariant.H7} align="left"> | |||
| <Text variant={TextVariant.bodySm} textAlign="left"> | |||
There was a problem hiding this comment.
Suggested change
| <Text variant={TextVariant.bodySm} textAlign="left"> | |
| <Text variant={TextVariant.bodySm} textAlign="left" as="h6"> |
| ) : ( | ||
| <Typography variant={TypographyVariant.H7} align="left"> | ||
| <Text variant={TextVariant.bodySm} textAlign="left"> |
There was a problem hiding this comment.
Suggested change
| <Text variant={TextVariant.bodySm} textAlign="left"> | |
| <Text variant={TextVariant.bodySm} textAlign="left" as="h6"> |
| boxProps={{ alignItems: AlignItems.center, display: DISPLAY.FLEX }} | ||
| variant={TypographyVariant.H6} | ||
| variant={TextVariant.bodySm} |
There was a problem hiding this comment.
Suggested change
| variant={TextVariant.bodySm} | |
| variant={TextVariant.bodySm} | |
| as="h6" |
| @@ -217,7 +217,7 @@ export default class ConfirmPageContainerContent extends Component { | |||
| className="actionable-message--warning" | |||
| message={ | |||
| isBuyableChain ? ( | |||
| <Typography variant={TypographyVariant.H7} align="left"> | |||
| <Text variant={TextVariant.bodySm} align="left"> | |||
There was a problem hiding this comment.
Suggested change
| <Text variant={TextVariant.bodySm} align="left"> | |
| <Text variant={TextVariant.bodySm} textAlign="left" as="h6"> |
| ) : ( | ||
| <Typography variant={TypographyVariant.H7} align="left"> | ||
| <Text variant={TextVariant.bodySm} align="left"> |
There was a problem hiding this comment.
Suggested change
| <Text variant={TextVariant.bodySm} align="left"> | |
| <Text variant={TextVariant.bodySm} textAlign="left" as="h6"> |
|
Hey @SawanKumarBhagat any chance you could do a rebase and make the suggested updates to this PR in the next 2 weeks? Otherwise I will close. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ient
Explanation
replace with and TypographyVarient with TextVarient
Updating Typography to Text
metamask-extension\ui\components\app\asset-list\asset-list.js
metamask-extension\ui\components\app\beta-header\index.js
metamask-extension\ui\components\app\cancel-speedup-popover\cancel-speedup-popover.js
metamask-extension\ui\components\app\confirm-page-container\confirm-page-container.component.js
metamask-extension\ui\components\app\confirm-page-container\confirm-page-container-content\confirm-page-container-content.component.js
Part of: #17670
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.