Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade @metamask/eth-ledger-bridge-keyring #14799

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Upgrade @metamask/eth-ledger-bridge-keyring #14799

merged 3 commits into from
Jun 1, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented May 30, 2022

Fixes: #6012

Upgrade @metamask/eth-ledger-bridge-keyring to fix issue with ledger accounts.

@jpuri jpuri requested review from darkwing, Gudahtt and danjm May 30, 2022 09:13
@jpuri jpuri requested a review from a team as a code owner May 30, 2022 09:13
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

digiwand
digiwand previously approved these changes May 31, 2022
View reviewed changes
@jpuri jpuri requested a review from digiwand June 1, 2022 14:42
darkwing
darkwing approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, everything works!

@metamaskbot
Copy link
Collaborator

Builds ready [4002648]
Page Load Metrics (1844 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89137105126
domContentLoaded16152161181314670
load16332184184416881
domInteractive16152161181314670

@jpuri jpuri merged commit 95c2301 into develop Jun 1, 2022
@jpuri jpuri deleted the ledger_issue_fix branch June 1, 2022 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@darkwing darkwing darkwing approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ledger Nano: Metamask Address does not correspond to Ledger
4 participants
@jpuri @metamaskbot @darkwing @digiwand