Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace local isSnapId definition with isSnapId from @metamask/snaps-utils #29422

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Dec 25, 2024

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? Deduplication of code
  2. What is the improvement/solution? Using the isSnapId function from the @metamask/snaps-utils package.

Related issues

Fixes: #29280

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@hmalik88 hmalik88 requested review from a team as code owners December 25, 2024 19:38
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added team-snaps-platform Snaps Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Dec 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1dd71a1]
Page Load Metrics (1863 ± 291 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34930981667578277
domContentLoaded140236071839603289
load140736331863606291
domInteractive22231575024
backgroundConnect86023157
firstReactRender15101623015
getState579232612
initialActions01000
loadScripts102829491397515247
setupStore67415188
uiStartup167640932250651313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use isSnapId from @metamask/snaps-utils
2 participants