Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use margin instead of padding for the Snaps UI Container #29385

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 20, 2024

Description

Use margin instead of padding for the Snaps UI Container. This fixes an issue where using certain components (such as Section) at the root would look weird.

Open in GitHub Codespaces

Screenshots/Recordings

Before

image

After

image

@FrederikBolding FrederikBolding requested a review from a team as a code owner December 20, 2024 12:08
@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Dec 20, 2024
}
}

&__error {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class was not actually in use.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [8e79f25]
Page Load Metrics (1699 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13982265170020799
domContentLoaded138922551673211101
load14502265169920598
domInteractive238334157
backgroundConnect977282211
firstReactRender1890422512
getState56517199
initialActions01000
loadScripts9921843125918689
setupStore65613136
uiStartup164225411967234113
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 863d77c Dec 20, 2024
85 checks passed
@FrederikBolding FrederikBolding deleted the fb/use-margin-instead-of-padding branch December 20, 2024 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants