Skip to content

Commit

Permalink
fix: Use margin instead of padding for the Snaps UI Container (#29385)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Use `margin` instead of `padding` for the Snaps UI Container. This fixes
an issue where using certain components (such as Section) at the root
would look weird.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29385?quickstart=1)

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


![image](https://github.com/user-attachments/assets/ba7950e6-d41a-411d-aba1-a156a74efaad)


### **After**


![image](https://github.com/user-attachments/assets/c7e475d4-8b61-4ec9-ac55-084c0bb8e2df)
  • Loading branch information
FrederikBolding authored Dec 20, 2024
1 parent 29cbe95 commit 863d77c
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions ui/components/app/snaps/snap-ui-renderer/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,10 @@
&__container {
& > *:first-child {
gap: 16px;
padding: 16px;
margin: 16px;
}
}

&__error {
margin-top: 0 !important;
}

&__spinner {
width: 30px;
}
Expand Down

0 comments on commit 863d77c

Please sign in to comment.