ci: Migrate LavaMoat validation to GitHub Actions #29369

Gudahtt · 2024-12-20T03:55:27Z

Description

Migrate LavaMoat policy validation from CircleCI to GitHub actions. No functional changes.

Related issues

Relates to #28572

These changes were extracted from #29256

Manual testing steps

Checkout this branch (migrate-lavamoat-validation), then from there create a new branch to test with
On this new branch, make a dependency change with a policy impact (e.g. add or remove a package, upgrade something, etc.), but make sure the build still passes (validation requires a passing build)
Create a draft PR, and verify that the policy validation fails
Use the metamaskbot update-policies bot command to update the policies, then verify the validation now succeeds.
PR with errors - chore: Temp testing lavamoat migration #29396
Failure - https://github.com/MetaMask/metamask-extension/actions/runs/12434996100/job/34719873040?pr=29396
Passing - https://github.com/MetaMask/metamask-extension/actions/runs/12435253146/job/34720674397?pr=29396

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-12-20T04:42:02Z

Builds ready [bbf4c5e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1873 ± 127 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1572	2519	1881	266	128
		domContentLoaded	1561	2426	1848	255	122
		load	1576	2516	1873	265	127
		domInteractive	17	370	68	80	39
		backgroundConnect	11	90	27	18	9
		firstReactRender	17	80	44	25	12
		getState	5	82	31	26	13
		initialActions	0	1	0	0	0
		loadScripts	1047	1812	1371	209	100
		setupStore	7	80	17	19	9
		uiStartup	1764	2901	2129	289	139

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

hjetpoluru

LGTM

desi · 2024-12-20T17:53:46Z

.github/workflows/validate-lavamoat-policy-webapp.yml

+      - name: Validate lavamoat ${{ matrix.build-type }} policy
+        run: yarn lavamoat:webapp:auto:ci --build-types=${{ matrix.build-type }}
+        env:
+          INFURA_PROJECT_ID: 00000000000


Should this be an ENV var? or could you explain what that id is?

Good question! This is the single required environment variable for our build process. Generating an application LavaMoat policy requires building the project, so we needed to set it to something. But since this is a mock value that we don't want to use elsewhere, it's set inline directly.

The same strategy is used in the existing "Update LavaMoat policies" workflow:

metamask-extension/.github/workflows/update-lavamoat-policies.yml

Line 120 in 695d0db

INFURA_PROJECT_ID: 00000000000

Ah! Thanks for the explanation!

desi

LGTM

Gudahtt · 2024-12-20T18:58:59Z

Rebased to resolve conflicts

metamaskbot · 2024-12-20T19:38:06Z

Builds ready [b84c0a5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1570 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	235	1758	1512	309	148
		domContentLoaded	1372	1692	1544	83	40
		load	1380	1757	1570	97	46
		domInteractive	23	66	39	15	7
		backgroundConnect	6	87	31	23	11
		firstReactRender	15	94	45	29	14
		getState	4	34	9	6	3
		initialActions	0	1	0	0	0
		loadScripts	1008	1289	1153	77	37
		setupStore	6	54	12	14	7
		uiStartup	1607	2286	1825	178	85

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Migrate LavaMoat policy validation from CircleCI to GitHub actions. No functional changes. Relates to #28572

Gudahtt · 2024-12-20T20:20:08Z

Rebased to resolve conflicts again

metamaskbot · 2024-12-20T20:52:34Z

Builds ready [5fdda05]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1597 ± 39 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	258	1757	1532	305	146
		domContentLoaded	1435	1728	1576	81	39
		load	1439	1746	1597	81	39
		domInteractive	15	122	39	24	12
		backgroundConnect	8	61	23	18	9
		firstReactRender	16	88	50	27	13
		getState	4	54	10	11	5
		initialActions	0	0	0	0	0
		loadScripts	1056	1363	1159	72	35
		setupStore	6	55	12	14	7
		uiStartup	1676	2317	1885	199	95

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Gudahtt added the team-extension-platform label Dec 20, 2024

Gudahtt assigned hjetpoluru Dec 20, 2024

metamaskbot added the team-wallet-framework label Dec 20, 2024

Gudahtt marked this pull request as ready for review December 20, 2024 04:44

Gudahtt requested a review from a team as a code owner December 20, 2024 04:44

hjetpoluru assigned Gudahtt and unassigned hjetpoluru Dec 20, 2024

hjetpoluru self-requested a review December 20, 2024 15:22

hjetpoluru mentioned this pull request Dec 20, 2024

chore: Temp testing lavamoat migration #29396

Draft

7 tasks

hjetpoluru previously approved these changes Dec 20, 2024

View reviewed changes

desi reviewed Dec 20, 2024

View reviewed changes

desi previously approved these changes Dec 20, 2024

View reviewed changes

Gudahtt dismissed stale reviews from desi and hjetpoluru via e5581da December 20, 2024 18:58

Gudahtt force-pushed the migrate-lavamoat-validation branch from bbf4c5e to e5581da Compare December 20, 2024 18:58

desi previously approved these changes Dec 20, 2024

View reviewed changes

Gudahtt enabled auto-merge December 20, 2024 19:44

AugmentedMode previously approved these changes Dec 20, 2024

View reviewed changes

Gudahtt added this pull request to the merge queue Dec 20, 2024

hjetpoluru self-requested a review December 20, 2024 19:48

hjetpoluru previously approved these changes Dec 20, 2024

View reviewed changes

Gudahtt removed this pull request from the merge queue due to a manual request Dec 20, 2024

Gudahtt added 3 commits December 20, 2024 16:49

chore: Migrate LavaMoat validation to GitHub Actions

653d121

Migrate LavaMoat policy validation from CircleCI to GitHub actions. No functional changes. Relates to #28572

Add mock Infura project ID

46954db

Fix merge conflict

5fdda05

Gudahtt dismissed stale reviews from hjetpoluru and AugmentedMode via 5fdda05 December 20, 2024 20:19

Gudahtt dismissed desi’s stale review via 5fdda05 December 20, 2024 20:19

Gudahtt force-pushed the migrate-lavamoat-validation branch from b84c0a5 to 5fdda05 Compare December 20, 2024 20:19

Gudahtt enabled auto-merge December 20, 2024 20:20

hjetpoluru self-requested a review December 20, 2024 20:28

hjetpoluru approved these changes Dec 20, 2024

View reviewed changes

desi approved these changes Dec 20, 2024

View reviewed changes

Gudahtt added this pull request to the merge queue Dec 20, 2024

Merged via the queue into main with commit ce8b502 Dec 20, 2024
77 checks passed

Gudahtt deleted the migrate-lavamoat-validation branch December 20, 2024 21:27

github-actions bot locked and limited conversation to collaborators Dec 20, 2024

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Migrate LavaMoat validation to GitHub Actions #29369

ci: Migrate LavaMoat validation to GitHub Actions #29369

Gudahtt commented Dec 20, 2024 •

edited by hjetpoluru

Loading

metamaskbot commented Dec 20, 2024

hjetpoluru left a comment

desi Dec 20, 2024

Gudahtt Dec 20, 2024

desi Dec 20, 2024

desi left a comment

Gudahtt commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

Gudahtt commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

ci: Migrate LavaMoat validation to GitHub Actions #29369

ci: Migrate LavaMoat validation to GitHub Actions #29369

Conversation

Gudahtt commented Dec 20, 2024 • edited by hjetpoluru Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Dec 20, 2024

hjetpoluru left a comment

Choose a reason for hiding this comment

desi Dec 20, 2024

Choose a reason for hiding this comment

Gudahtt Dec 20, 2024

Choose a reason for hiding this comment

desi Dec 20, 2024

Choose a reason for hiding this comment

desi left a comment

Choose a reason for hiding this comment

Gudahtt commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

Gudahtt commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

Gudahtt commented Dec 20, 2024 •

edited by hjetpoluru

Loading