fix: remove reliance on transaction decode in confirmations

[matthewwalsh0]

Description

Disable all advanced transaction data decoding using Sourcify, 4Byte and Uniswap, if the Decode smart contracts toggle is disabled.

Remove all reliance on the advanced decoding excluding the Data section.

Specifically:

• Create useTokenTransactionData hook to decode all token transactions locally using the ABIs.
• Replace all usages of useDecodedTransactionData with the new hook, except for the TransactionData component.
• Update related unit and integration tests to decode valid test data rather than rely on mocking hooks.

Related issues

Manual testing steps

Regression of redesigned transaction confirmations.

Specifically:

• Token Transfer Recipient
• Token Transfer Amount
• Approval Spender
• Approval Spending Cap

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[metamaskbot]

Builds ready [9678571]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1626 ± 60 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1447	1899	1634	130	63
		domContentLoaded	1424	1814	1603	119	57
		load	1447	1888	1626	125	60
		domInteractive	21	86	42	20	10
		backgroundConnect	8	71	23	18	9
		firstReactRender	16	105	49	32	16
		getState	5	64	17	19	9
		initialActions	0	1	0	0	0
		loadScripts	1053	1413	1198	112	54
		setupStore	6	81	23	28	13
		uiStartup	1656	2399	1989	197	95

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: -996 Bytes (-0.01%)
• common: 0 Bytes (0.00%)

[danjm]

For the sake of immediately resolving the privacy regression, is there anything more needed than just the above two lines?

[matthewwalsh0]

Afraid so, the redesigned confirmations are incorrectly reliant on the advanced decoding meaning they would lose core functionality if it were disabled. Hence the additional changes to use local decoding.

[danjm]

would they lose functionality that was available on the old designs, if decoding was disabled?

[matthewwalsh0]

Afraid so, fundamental data such as token transfer recipient and approve spending cap.

[metamaskbot]

Builds ready [3644b3e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1898 ± 76 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1533	2149	1897	160	77
		domContentLoaded	1484	2082	1864	153	73
		load	1492	2151	1898	159	76
		domInteractive	29	104	43	17	8
		backgroundConnect	9	83	35	25	12
		firstReactRender	16	74	36	23	11
		getState	7	64	23	20	10
		initialActions	0	1	0	0	0
		loadScripts	1107	1617	1400	137	66
		setupStore	7	60	13	12	6
		uiStartup	1722	2433	2165	172	83

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: -996 Bytes (-0.01%)
• common: -155 Bytes (-0.00%)

[jpuri]

Great work

[metamaskbot]

Builds ready [3c6dcba]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1578 ± 49 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1417	1832	1582	106	51
		domContentLoaded	1406	1764	1556	105	50
		load	1411	1787	1578	102	49
		domInteractive	23	56	30	9	4
		backgroundConnect	7	57	23	18	9
		firstReactRender	15	75	28	21	10
		getState	4	56	12	15	7
		initialActions	0	1	0	0	0
		loadScripts	951	1366	1146	104	50
		setupStore	6	56	12	14	7
		uiStartup	1569	2070	1795	118	57

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: -1014 Bytes (-0.01%)
• common: -161 Bytes (-0.00%)