Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy settings: Check “IPFS gateway” toggle works correctly #21964

Closed
chloeYue opened this issue Nov 23, 2023 · 1 comment
Closed

Privacy settings: Check “IPFS gateway” toggle works correctly #21964

chloeYue opened this issue Nov 23, 2023 · 1 comment
Assignees
Labels
area-documentation Issues relating to documentation, in the codebase and off. team-extension-platform

Comments

@chloeYue
Copy link
Contributor

No description provided.

@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Nov 23, 2023
@chloeYue chloeYue added area-documentation Issues relating to documentation, in the codebase and off. and removed INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. labels Nov 23, 2023
@benjisclowder benjisclowder self-assigned this Aug 29, 2024
benjisclowder added a commit that referenced this issue Sep 11, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR documents the manual test scenarios for several privacy settings
functionalities. Below is a summary of the validations included in these
manual scenarios:

1. Privacy settings: Check “network details check” toggle works
correctly

- Validate that the 'Network details check' toggle is present in the
Security & Privacy settings and is ON by default.
- Validate that the toggle can be turned on and off.
- Validate that when the toggle is turned on, MetaMask checks the
network details against the information provided by chainid.network when
attempting to connect to a blockchain network.

2. Privacy settings: Check “IPFS gateway” toggle works correctly

- Validate that the 'IPFS gateway' toggle is present in the Security &
Privacy settings and is ON by default.
- Validate that the toggle can be turned on and off.
- Validate that when the toggle is turned on, MetaMask shows images of
NFTs.
- Validate that when the toggle is turned off, NFT images are replaced
by placeholders and I am prompted to turn on IPFS resolution.

3. Privacy settings: Check “Show ENS domains in address bar” toggle
works correctly

- Validate that the 'Show ENS domains in address bar' toggle is present
in the Security & Privacy settings and is ON by default.
- Validate that the toggle can be turned on and off.
- Validate that when the toggle is turned on, ENS domain name is
displayed alongside the public address.

4. Privacy settings: Check “Display NFT Media” toggle works correctly

- Validate that the 'Display NFT media' toggle is present in the
Security & Privacy settings and is ON by default.
- Validate that the toggle can be turned on and off.
- Validate that when the toggle is turned on, MetaMask displays NFT
media and data.
- Validate that NFT autodetection relies on this setting and won't be
available when this is turned off.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26764?quickstart=1)

## **Related issues**

Fixes: #21963,
#21964,
#21966,
#21967

## **Manual testing steps**

Please click link for the [rendered
view](https://github.com/MetaMask/metamask-extension/tree/privacy-settings-manual-scenarios/test/manual-scenarios/privacy-settings)

--> test/manual-scenarios/privacy-settings/check "Network details check"
toggle works correctly.md

https://github.com/user-attachments/assets/9a60b564-7503-44b9-9ca0-810e857a4529

--> test/manual-scenarios/privacy-settings/check "IPFS gateway" toggle
works correctly.md

https://github.com/user-attachments/assets/3e2e5135-9343-4d8c-808f-e3f599928d52

--> test/manual-scenarios/privacy-settings/check "Show ENS domains in
address bar" toggle works correctly.md

https://github.com/user-attachments/assets/79df9cc4-0083-458f-be06-d524c7ca135f

--> test/manual-scenarios/privacy-settings/check "Display NFT media"
toggle works correctly.md

https://github.com/user-attachments/assets/a54ef74f-00b4-4554-a7ac-9cd1e53800a4

---------

Co-authored-by: Harika <[email protected]>
@benjisclowder
Copy link
Contributor

Documented here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Issues relating to documentation, in the codebase and off. team-extension-platform
Projects
None yet
Development

No branches or pull requests

3 participants