Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Firefox import keystore JSON #20837

Closed
pociej opened this issue Sep 12, 2023 · 8 comments
Closed

[Bug]: Firefox import keystore JSON #20837

pociej opened this issue Sep 12, 2023 · 8 comments
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-accounts type-bug

Comments

@pociej
Copy link

pociej commented Sep 12, 2023

Describe the bug

Importing password protected keystore JSON doesnt work in firefox. Once file selection window popus up metamask plugin widget disappears and there is no option to provide password.

Steps to reproduce

  1. Open plugin widget in FF go to accounts -> imports -> JSON

Error messages or log output

No response

Version

11.0.0

Build type

None

Browser

Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

@anaamolnar
Copy link

Hello, @pociej. Thank you for taking the time to report this issue! Do you experience the same problem when trying to import in Metamask in Brave or Chrome, or does it work as expected? Thank you!

@anaamolnar anaamolnar added needs-reproduction needs-information Needs additional information from the user who reported the issue labels Sep 13, 2023
@pociej
Copy link
Author

pociej commented Sep 13, 2023

hi @anaamolnar yes Chrome and Brave works. I checked FF on different machines and operating systems. And i can confirm problem was the same everywhere.

@plasmacorral
Copy link
Contributor

plasmacorral commented Sep 13, 2023

Thank you for sharing your experience here, @pociej, I am sorry for the frustration. This behavior and performance is not ideal. If the issue is specific to having MM open in the pop-up view, I can recommend a potential work around to help you get this account imported into the Firefox extension.

  1. Open MM
  2. Select the kebab menu (3 dots on the right corner)
  3. Select Expand View From this point forward you should have MM open in the full browser window
  4. Hit the Accounts drop down menu
  5. Select Import account
  6. Hit the dropdown to select JSON file
  7. enter optional password as needed
  8. Select import
  9. Be extraordinarily patient, and do not stop the page.
  10. Account is imported and active

There is a previously reported issue that impacts the ability to import from the pop-up (smaller) window. I will add to that existing impact that we have impact on Firefox 117, as we can observe today.

From within that report there is another issue cited about poor performance when importing JSON. In my experience reproducing this today as far back as 10.34, Firefox would present the message A web page is slowing down Firefox. To speed up your browser, stop that page. If you allow it to keep running the account will be successfully imported. In an observation I noted within one of these earlier tickets, if the browser crashed, the new account would appear on relaunch.

There is also a message that appears, but I notice that it is partially obscured by the Import account box. It says: Expect this JSON import to take a few minutes and freeze MetaMask. We apologize, and we will make it faster in the future.

@plasmacorral plasmacorral added Sev2-normal Normal severity; minor loss of service or inconvenience. and removed needs-reproduction needs-information Needs additional information from the user who reported the issue labels Sep 13, 2023
@plasmacorral plasmacorral changed the title [Bug]: FF import keystore JSON [Bug]: Firefox import keystore JSON Sep 13, 2023
@pociej
Copy link
Author

pociej commented Sep 14, 2023

@plasmacorral. Thx for quick reply. Yeah I noticed expanded view is kind of workarround. But its not an good solution IMO.
While I or you or other dev can use workarround end user of the app is customer not me. And posting inside the app such instructions is unacceptable UX. Do you plan to solve it?

@plasmacorral
Copy link
Contributor

@pociej This is something that I too would like to see fixed and will work with the team to try and get it prioritized.

@pociej
Copy link
Author

pociej commented Oct 12, 2023

@plasmacorral is there any update in this issue? Do you need help in fixing the problem? Im open to PR.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jan 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 19, 2024
Copy link
Contributor

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale team-accounts type-bug
Projects
Archived in project
Development

No branches or pull requests

3 participants