[Bug]: Importing an Account from a JSON file causes MM to freeze and eventually crash

[seaona]

Describe the bug

Problem: when I am trying to import an account from a JSON file, MetaMask get's frozen and it eventually crashes.
Might be that the JSON file is not 100% correct, so we should handle these situations without causing MM to crash.

import-acct-from-json.mp4

Steps to reproduce

0. On your computer, create a file and save it as test.json containing this:

{"version":3,"id":"812dc267-b20e-4df4-bb7b-f0c9bb413976","address":"67d30ef950015ab1a03e30ed5d5f2a26de196c4d","crypto":{"ciphertext":"4523eecd6ec040dabe718554b3a8fbd3075452963221d7bba1d406507b481bf5","cipherparams":{"iv":"657b767dfbb92ddce660e079d4408572"},"cipher":"aes-128-ctr","kdf":"scrypt","kdfparams":{"dklen":32,"salt":"1fb3047dac934d1da0293f3c71ac201b49a5f777294b95cb1502616130f54bcd","n":262144,"r":8,"p":1},"mac":"84fca73cc93bccaffdbee739314af5ad3c2f8492bc82b8366dac86541e02b71a"}}

1. Go to MM
2. Click Import Account
3. Select JSON File that you just created
4. Insert password. For this case it's: 123
5. Click Import -- see how MM freezes

Error messages or log output

No response

Version

10.24.0

Build type

None

Browser

Chrome
ADDED 09/13/2023: Firefox 117

Operating system

Linux
ADDED 09/13/2023: Mac w/Firefox

Hardware wallet

No response

Additional context

No response

[plasmacorral]

Able to reproduce this on Mac M1 running Ventura 13.3.1 with production v10.30.4. On relaunch, imported account did appear.

Screen.Recording.2023-05-24.at.4.28.19.PM.mov

[gantunesr]

Possible fix is an UI/UX update to indicate the account is "loading"

[plasmacorral]

This is confirmed to also impact Firefox 117 on Mac Ventura 13.5.2 in versions 10.34, 10.35.1 and 11.0.0 #20837

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

[github-actions]

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

[gantunesr]

@plasmacorral to validate if the issue persists

[plasmacorral]

Retested today with the same test.json file in Firefox 128.0.0 on Mac Sonoma 14.5 with version v11.16.5, issue persists. Firefox appears to not respond at all or ask for the password when I attempt to import. The account does not appear on the account list and no obvious console errors observed.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.