Skip to content

Commit

Permalink
fix: cherry-pick Snaps feature flag to RC (#23384)
Browse files Browse the repository at this point in the history
## **Description**

Cherry-picks 9ee8738 to the RC.
  • Loading branch information
FrederikBolding authored Mar 7, 2024
1 parent 88db23b commit f733927
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
1 change: 0 additions & 1 deletion shared/constants/permissions.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ describe('EndowmentPermissions', () => {
expect(Object.keys(EndowmentPermissions).sort()).toStrictEqual(
[
'endowment:name-lookup',
'endowment:page-home',
...Object.keys(endowmentPermissionBuilders).filter(
(targetName) =>
!Object.keys(ExcludedSnapEndowments).includes(targetName),
Expand Down
4 changes: 1 addition & 3 deletions shared/constants/snaps/permissions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export const EndowmentPermissions = Object.freeze({
'endowment:rpc': 'endowment:rpc',
'endowment:webassembly': 'endowment:webassembly',
'endowment:lifecycle-hooks': 'endowment:lifecycle-hooks',
///: BEGIN:ONLY_INCLUDE_IF(build-flask)
'endowment:page-home': 'endowment:page-home',
///: BEGIN:ONLY_INCLUDE_IF(build-flask)
'endowment:name-lookup': 'endowment:name-lookup',
///: END:ONLY_INCLUDE_IF
///: BEGIN:ONLY_INCLUDE_IF(keyring-snaps)
Expand All @@ -25,8 +25,6 @@ export const ExcludedSnapEndowments = Object.freeze({
'endowment:signature-insight':
'This endowment is in development and therefore not available.',
///: BEGIN:ONLY_INCLUDE_IF(build-main)
'endowment:page-home':
'This endowment is experimental and therefore not available.',
'endowment:name-lookup':
'This endowment is experimental and therefore not available.',
///: END:ONLY_INCLUDE_IF
Expand Down
1 change: 0 additions & 1 deletion test/e2e/run-all.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ const { loadBuildTypesConfig } = require('../../development/lib/build-type');
const FLASK_ONLY_TESTS = [
'test-snap-txinsights-v2.spec.js',
'test-snap-namelookup.spec.js',
'test-snap-homepage.spec.js',
];

const getTestPathsForTestDir = async (testDir) => {
Expand Down

0 comments on commit f733927

Please sign in to comment.