fix: sort by cost (metadata)

MetaMask · Nov 15, 2024 · e987faa · e987faa
1 parent cd4e423
commit e987faa
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 10 deletions.
diff --git a/ui/ducks/bridge/bridge.ts b/ui/ducks/bridge/bridge.ts
@@ -34,7 +34,7 @@ const initialState: BridgeState = {
   fromTokenExchangeRate: null,
   toNativeExchangeRate: null,
   toTokenExchangeRate: null,
-  sortOrder: SortOrder.ADJUSTED_RETURN_DESC,
+  sortOrder: SortOrder.COST_ASC,
   selectedQuote: null,
 };
 

diff --git a/ui/ducks/bridge/selectors.test.ts b/ui/ducks/bridge/selectors.test.ts
@@ -776,7 +776,7 @@ describe('Bridge selectors', () => {
 
     it('should recommend 2nd cheapest quote if ETA exceeds 1 hour', () => {
       const state = createBridgeMockStore({
-        bridgeSliceOverrides: { sortOrder: SortOrder.ADJUSTED_RETURN_DESC },
+        bridgeSliceOverrides: { sortOrder: SortOrder.COST_ASC },
         bridgeStateOverrides: {
           quotes: [
             mockBridgeQuotesNativeErc20[1],

diff --git a/ui/ducks/bridge/selectors.ts b/ui/ducks/bridge/selectors.ts
@@ -271,13 +271,9 @@ const _getSortedQuotesWithMetadata = createDeepEqualSelector(
           (quote) => quote.estimatedProcessingTimeInSeconds,
           'asc',
         );
-      case SortOrder.ADJUSTED_RETURN_DESC:
+      case SortOrder.COST_ASC:
       default:
-        return orderBy(
-          quotesWithMetadata,
-          ({ adjustedReturn }) => adjustedReturn.fiat,
-          'desc',
-        );
+        return orderBy(quotesWithMetadata, ({ cost }) => cost.fiat, 'asc');
     }
   },
 );

diff --git a/ui/pages/bridge/quotes/bridge-quotes-modal.tsx b/ui/pages/bridge/quotes/bridge-quotes-modal.tsx
@@ -64,7 +64,7 @@ export const BridgeQuotesModal = ({
         {/* HEADERS */}
         <Row padding={[4, 3]} paddingBottom={1}>
           {[
-            [SortOrder.ADJUSTED_RETURN_DESC, t('bridgeNetCost')],
+            [SortOrder.COST_ASC, t('bridgeNetCost')],
             [SortOrder.ETA_ASC, t('time')],
           ].map(([sortOrderOption, label]) => (
             <ButtonLink

diff --git a/ui/pages/bridge/types.ts b/ui/pages/bridge/types.ts
@@ -16,7 +16,7 @@ export type QuoteMetadata = {
 
 // Sort order set by the user
 export enum SortOrder {
-  ADJUSTED_RETURN_DESC,
+  COST_ASC,
   ETA_ASC,
 }