fix: don't render attribute aria-invalid="false" (#20939)

MetaMask · Oct 14, 2023 · e614498 · e614498
1 parent c23b1b5
commit e614498
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/ui/components/component-library/input/input.tsx b/ui/components/component-library/input/input.tsx
@@ -47,7 +47,7 @@ export const Input: InputComponent = React.forwardRef(
         },
         className,
       )}
-      aria-invalid={error}
+      {...(error && { 'aria-invalid': error })}
       as="input"
       autoComplete={autoComplete ? 'on' : 'off'}
       autoFocus={autoFocus}

diff --git a/ui/components/component-library/text-field/text-field.js b/ui/components/component-library/text-field/text-field.js
@@ -113,7 +113,7 @@ export const TextField = ({
     >
       {startAccessory}
       <InputComponent
-        aria-invalid={error}
+        {...(error && { 'aria-invalid': error })}
         autoComplete={autoComplete}
         autoFocus={autoFocus}
         backgroundColor={BackgroundColor.transparent}

diff --git a/ui/pages/keychains/__snapshots__/reveal-seed.test.js.snap b/ui/pages/keychains/__snapshots__/reveal-seed.test.js.snap
@@ -91,7 +91,6 @@ exports[`Reveal Seed Page should match snapshot 1`] = `
         class="box mm-text-field mm-text-field--size-lg mm-text-field--focused mm-text-field--truncate box--display-inline-flex box--flex-direction-row box--align-items-center box--width-full box--background-color-background-default box--rounded-sm box--border-width-1 box--border-style-solid"
       >
         <input
-          aria-invalid="false"
           autocomplete="off"
           class="mm-box mm-text mm-input mm-input--disable-state-styles mm-text-field__input mm-text--body-md mm-box--margin-0 mm-box--padding-0 mm-box--padding-right-4 mm-box--padding-left-4 mm-box--color-text-default mm-box--background-color-transparent mm-box--border-style-none"
           data-testid="input-password"