Skip to content

Commit

Permalink
test: add e2e to swap with snap account (#25558)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
This adds an e2e test that creates a new snap account with Snap Simple
Keyring (SSK) and completes a swap from ETH to DAI in synchronous mode
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25558?quickstart=1)

## **Related issues**

Fixes:  [469](https://github.com/MetaMask/accounts-planning/issues/469)

## **Manual testing steps**

1. `yarn build:test:mv2` then `ENABLE_MV3=false yarn test:e2e:single
test/e2e/accounts/snap-account-eth-swap.spec.ts --browser=firefox`
2. `yarn build:test` then `yarn test:e2e:single
test/e2e/accounts/snap-account-eth-swap.spec.ts --browser=chrome`


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
plasmacorral authored Jul 2, 2024
1 parent 4886a3f commit c641981
Showing 1 changed file with 48 additions and 0 deletions.
48 changes: 48 additions & 0 deletions test/e2e/accounts/snap-account-eth-swap.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import { withFixtures, defaultGanacheOptions, WINDOW_TITLES } from '../helpers';
import { Driver } from '../webdriver/driver';
import FixtureBuilder from '../fixture-builder';
import {
buildQuote,
reviewQuote,
waitForTransactionToComplete,
checkActivityTransaction,
} from '../tests/swaps/shared';
import { installSnapSimpleKeyring } from './common';

const DAI = 'DAI';
const TEST_ETH = 'TESTETH';

describe('Snap Account - Swap', function () {
it('swaps ETH for DAI using a snap account', async function () {
await withFixtures(
{
fixtures: new FixtureBuilder().build(),
ganacheOptions: defaultGanacheOptions,
title: this.test?.fullTitle(),
},
async ({ driver }: { driver: Driver }) => {
await installSnapSimpleKeyring(driver, false);
await driver.switchToWindowWithTitle(
WINDOW_TITLES.ExtensionInFullScreenView,
);
await buildQuote(driver, {
amount: 0.001,
swapTo: DAI,
});
await reviewQuote(driver, {
amount: 0.001,
swapFrom: TEST_ETH,
swapTo: DAI,
});
await driver.clickElement({ text: 'Swap', tag: 'button' });
await waitForTransactionToComplete(driver, { tokenName: 'DAI' });
await checkActivityTransaction(driver, {
index: 0,
amount: '0.001',
swapFrom: TEST_ETH,
swapTo: DAI,
});
},
);
});
});

0 comments on commit c641981

Please sign in to comment.