Skip to content

Commit

Permalink
test: fix flaky test in account-token-list.spec.js (#23450)
Browse files Browse the repository at this point in the history
## **Description**

Reason of flakiness is race condition: we assert value as soon as we
found the element, the real value has not been rendered


## **Related issues**

Fixes: #23451

## **Manual testing steps**

Run test multiple times with `yarn test:e2e:single --browser=chrome
test/e2e/tests/settings/account-token-list.spec.js`

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
chloeYue authored Mar 13, 2024
1 parent 7b05334 commit 9c3835e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/e2e/tests/settings/account-token-list.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ describe('Settings', function () {
const tokenListAmount = await driver.findElement(
'[data-testid="multichain-token-list-item-value"]',
);
await driver.waitForNonEmptyElement(tokenListAmount);
assert.equal(await tokenListAmount.getText(), tokenValue);

await driver.clickElement('[data-testid="account-menu-icon"]');
Expand Down

0 comments on commit 9c3835e

Please sign in to comment.