make sure footer link displays warning modal

MetaMask · Dec 5, 2024 · 921c0e8 · 921c0e8
1 parent caa3a17
commit 921c0e8
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/ui/components/multichain/notification-detail-button/notification-detail-button.tsx b/ui/components/multichain/notification-detail-button/notification-detail-button.tsx
@@ -40,6 +40,8 @@ export const NotificationDetailButton = ({
   const isMetaMaskUrl = href.startsWith('metamask:');
   const [isOpen, setIsOpen] = useState(false);
 
+  const isSnapNotification = notification.type === TRIGGER_TYPES.SNAP;
+
   const handleModalClose = () => {
     setIsOpen(false);
   };
@@ -66,7 +68,7 @@ export const NotificationDetailButton = ({
       },
     });
 
-    if (notification.type === TRIGGER_TYPES.SNAP) {
+    if (isSnapNotification) {
       if (isMetaMaskUrl) {
         navigate(href);
       } else {
@@ -77,7 +79,7 @@ export const NotificationDetailButton = ({
 
   return (
     <>
-      {notification.type === TRIGGER_TYPES.SNAP && (
+      {isSnapNotification && (
         <SnapLinkWarning
           isOpen={isOpen}
           onClose={handleModalClose}
@@ -86,7 +88,7 @@ export const NotificationDetailButton = ({
       )}
       <Button
         key={id}
-        href={!isMetaMaskUrl && href ? href : undefined}
+        href={!isSnapNotification && href ? href : undefined}
         variant={variant}
         externalLink={isExternal || !isMetaMaskUrl}
         size={ButtonSize.Lg}