Skip to content

Commit

Permalink
fix: updating close icon svg (#27235)
Browse files Browse the repository at this point in the history
## **Description**

This pull request updates the close icon SVG to match the design
specifications. The existing SVG used in the code was inconsistent with
the design provided by the design team, so this change replaces it with
the correct version to ensure visual consistency across the application.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27235?quickstart=1)

## **Related issues**

Fixes: #27234


## **Manual Testing Steps**

1. Navigate to any part of the application where the close icon is
displayed.
2. Verify that the close icon matches the design specification.
3. Test the icon in various browsers (Chrome, Firefox, etc.) to ensure
it displays correctly.
4. Test on both light and dark modes (if applicable).
5. Verify the close icon’s appearance in different screen sizes
(desktop, tablet, mobile).

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="480" alt="Screenshot 2024-09-17 at 7 45 29 PM"
src="https://github.com/user-attachments/assets/100d04b1-0ada-46ed-8bc4-d0ffa7c8e20f">

<img width="1511" alt="Screenshot 2024-09-17 at 7 39 56 PM"
src="https://github.com/user-attachments/assets/3f122d00-2219-483a-898b-78657208cd90">

### **After**

<img width="467" alt="Screenshot 2024-09-17 at 7 45 48 PM"
src="https://github.com/user-attachments/assets/cc063328-f99e-4a35-a195-efec2da76455">

<img width="1508" alt="Screenshot 2024-09-17 at 7 40 13 PM"
src="https://github.com/user-attachments/assets/1e9f9b66-a42a-44eb-9bab-0f4aec3cc423">


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
georgewrmarshall authored Sep 18, 2024
1 parent 978ed66 commit 832e6fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/images/icons/close.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 832e6fc

Please sign in to comment.