-
Notifications
You must be signed in to change notification settings - Fork 5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: display msg if tokenId already exists (#20940)
## Explanation This PR adds displaying an error msg when the nft has been already imported. This avoids seeing the same nft twice when the user first imports tokenId(decimal value) then imports it again (hex value). * Fixes #MMASSETS-27 ## Screenshots/Screencaps ### Before Github issue : #18957 ### After 1- Mint and import nft with id 577 ![image](https://github.com/MetaMask/metamask-extension/assets/10994169/229a2ffb-7ab0-4bed-82fc-9ff8f0a8c69e) 2- Try importing Nft again with id 577 ![image](https://github.com/MetaMask/metamask-extension/assets/10994169/16106948-2bc2-4e1a-837d-d5073417a2a9) 3- Try importing Nft again with hex value: 0x241 ![image](https://github.com/MetaMask/metamask-extension/assets/10994169/f957585d-9b0d-47be-9964-39dfe639170a) ## Manual Testing Steps <!-- How should reviewers and QA manually test your changes? For instance: - Mint nft exp id 577 - Import the nft with id 577 - Try importing again with id 577 - Try importing again with 0x241 --> ## Pre-merge author checklist - [ ] I've clearly explained: - [x ] What problem this PR is solving - [ x] How this problem was solved - [x ] How reviewers can test my changes - [ ] Sufficient automated test coverage has been added ## Pre-merge reviewer checklist - [ ] Manual testing (e.g. pull and build branch, run in browser, test code being changed) - [ ] PR is linked to the appropriate GitHub issue - [ ] **IF** this PR fixes a bug in the release milestone, add this PR to the release milestone
- Loading branch information
1 parent
77b3b80
commit 707b2f4
Showing
4 changed files
with
154 additions
and
3 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters