update

MetaMask · Nov 28, 2024 · 5aee9e2 · 5aee9e2
1 parent 390dacc
commit 5aee9e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ui/pages/confirmations/hooks/useTypesSignSimulationEnabledInfo.test.ts b/ui/pages/confirmations/hooks/useTypesSignSimulationEnabledInfo.test.ts
@@ -24,7 +24,7 @@ describe('useTypesSignSimulationEnabledInfo', () => {
     expect(result.current).toBe(false);
   });
 
-  it('return false if request is not types sign v3 or V4', async () => {
+  it.only('return false if request is not types sign v3 or V4', async () => {
     const state = getMockTypedSignConfirmStateForRequest(
       unapprovedTypedSignMsgV1,
       {

diff --git a/ui/pages/confirmations/hooks/useTypesSignSimulationEnabledInfo.ts b/ui/pages/confirmations/hooks/useTypesSignSimulationEnabledInfo.ts
@@ -52,7 +52,7 @@ export function useTypesSignSimulationEnabledInfo() {
     signatureMethod === MESSAGE_TYPE.ETH_SIGN_TYPED_DATA_V3;
   const isPermit = isPermitSignatureRequest(currentConfirmation);
   const nonPermitSupportedByDecodingAPI =
-    isNonPermitSupportedByDecodingAPI(currentConfirmation);
+    isTypedSignV3V4 && isNonPermitSupportedByDecodingAPI(currentConfirmation);
 
   return useMemo(() => {
     if (!currentConfirmation) {
@@ -61,7 +61,7 @@ export function useTypesSignSimulationEnabledInfo() {
     return (
       useTransactionSimulations &&
       isTypedSignV3V4 &&
-      (isPermit || nonPermitSupportedByDecodingAPI) || true
+      (isPermit || nonPermitSupportedByDecodingAPI)
     );
   }, [isTypedSignV3V4, isPermit, nonPermitSupportedByDecodingAPI]);
 }