Move crazy substring to be inside the trycatch

MetaMask · Jul 13, 2022 · 59d57c3 · 59d57c3
1 parent e53bd44
commit 59d57c3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/scripts/controllers/transactions/index.js b/app/scripts/controllers/transactions/index.js
@@ -1461,12 +1461,12 @@ export default class TransactionController extends EventEmitter {
         // error ends up wrapped in a string & inside .value because of
         // https://github.com/ethjs/ethjs-rpc/blob/master/src/index.js#L52
         // https://github.com/ethjs/ethjs-query/blob/master/src/index.js#L78
-        let errorJson = error.message.substring(
-          error.message.indexOf("{"),
-          error.message.indexOf(',"code"')
-        ) + '}}}';
         let unwrapped;
         try {
+          let errorJson = error.message.substring(
+            error.message.indexOf("{"),
+            error.message.indexOf(',"code"')
+          ) + '}}}';
           errorJson = JSON.parse(errorJson);
           unwrapped = new Error(errorJson.value.data.message);
           unwrapped.code = errorJson.value.code;