Merge branch 'develop' into olu/test-scenario-eth-sign

MetaMask · Mar 12, 2024 · 564e263 · 564e263
2 parents 14533c8 + 1803b49
commit 564e263
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -28,7 +28,7 @@ executors:
     resource_class: small
   playwright:
     docker:
-      - image: mcr.microsoft.com/playwright:v1.41.1-focal
+      - image: mcr.microsoft.com/playwright:v1.42.1-focal
     resource_class: medium
 
 orbs:

diff --git a/test/e2e/mmi/Dockerfile b/test/e2e/mmi/Dockerfile
@@ -1,4 +1,4 @@
-FROM mcr.microsoft.com/playwright:v1.41.1-focal AS build
+FROM mcr.microsoft.com/playwright:v1.42.1-focal AS build
 
 WORKDIR '/usr/src/app'
 

diff --git a/test/e2e/mmi/specs/dapp.spec.ts b/test/e2e/mmi/specs/dapp.spec.ts
@@ -22,11 +22,7 @@ const dappsTest = async (
 
   // Sign and submit
   const statusName = await client.submitTransactionById(custodianTxId);
-  if (buttonId === 'useSuperPowers_sepolia') {
-    await mainPage.checkLastTransactionStatus(/Failed/iu);
-  } else {
-    await mainPage.checkLastTransactionStatus(statusName);
-  }
+  await mainPage.checkLastTransactionStatus(statusName);
   // Mined status not check as it makes tests flaky and it is blockchain performance dependent
 };
 
@@ -49,7 +45,7 @@ test.describe('MMI dapps', () => {
     await dappsTest(page, context, 'approveTokens');
   });
 
-  test('MMI connects to dapp, clicks "Use Super Powers" button, confirm from custody and check that the TX has failed', async ({
+  test('MMI connects to dapp, clicks "Use Super Powers" button, and confirm from custody', async ({
     page,
     context,
   }) => {

diff --git a/...on.visual.spec.ts-snapshots/token-replacement-notification-mmi-visual-linux.png b/...on.visual.spec.ts-snapshots/token-replacement-notification-mmi-visual-linux.png