${{ env.USE_CACHING }}

MetaMask · Dec 17, 2024 · 4bace58 · 4bace58
1 parent 67a59b0
commit 4bace58
Show file tree

Hide file tree

Showing 11 changed files with 25 additions and 19 deletions.
diff --git a/.github/workflows/add-release-label.yml b/.github/workflows/add-release-label.yml
@@ -20,7 +20,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       - name: Get the next semver version
         id: get-next-semver-version

diff --git a/.github/workflows/check-attributions.yml b/.github/workflows/check-attributions.yml
@@ -14,7 +14,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       - name: Check attributions changes
         run: yarn attributions:check
diff --git a/.github/workflows/check-pr-labels.yml b/.github/workflows/check-pr-labels.yml
@@ -23,7 +23,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       - name: Check PR has required labels
         env:

diff --git a/.github/workflows/check-template-and-add-labels.yml b/.github/workflows/check-template-and-add-labels.yml
@@ -16,7 +16,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       - name: Check template and add labels
         id: check-template-and-add-labels

diff --git a/.github/workflows/close-bug-report.yml b/.github/workflows/close-bug-report.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       - name: Close release bug report issue
         env:

diff --git a/.github/workflows/codespaces.yml b/.github/workflows/codespaces.yml
@@ -19,4 +19,4 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
diff --git a/.github/workflows/fitness-functions.yml b/.github/workflows/fitness-functions.yml
@@ -19,7 +19,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       - name: Run fitness functions
         env:

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -40,8 +40,8 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: false
-          should-cache-save: $USE_CACHING
+          should-cache-restore: 'false'
+          should-cache-save: ${{ env.USE_CACHING }}
 
   prep-build-test-webpack:
     needs: prep-deps
@@ -50,7 +50,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       # should add `--env production` to this but need `SEGMENT_PROD_WRITE_KEY`
       - run: yarn webpack --test --no-lavamoat --no-cache --browser=chrome --lockdown --sentry --snow
@@ -65,6 +65,8 @@ jobs:
   run-tests:
     needs: prep-deps
     uses: ./.github/workflows/run-tests.yml
+    with:
+      USE_CACHING: ${{ env.USE_CACHING }}
 
   run-pageload-benchmark:
     name: Run Benchmarks # So that the level 1 name will be "Run Benchmarks" in the GitHub Actions UI

diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -2,6 +2,10 @@ name: Run tests
 
 on:
   workflow_call:
+    inputs:
+      USE_CACHING:
+        required: true
+        type: string
     outputs:
       current-coverage:
         description: Current coverage
@@ -21,7 +25,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       - name: test:unit:coverage
         run: yarn test:unit:coverage --shard=${{ matrix.shard }}/${{ strategy.job-total }}
@@ -41,7 +45,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       - name: test:unit:webpack:coverage
         run: yarn test:unit:webpack:coverage
@@ -61,7 +65,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       - name: test:integration:coverage
         run: yarn test:integration:coverage
@@ -88,7 +92,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
 
       - name: Download artifacts
         uses: actions/download-artifact@v4

diff --git a/.github/workflows/update-attributions.yml b/.github/workflows/update-attributions.yml
@@ -61,7 +61,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
       - name: Get commit SHA
         id: commit-sha
         run: echo "COMMIT_SHA=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT"
@@ -85,7 +85,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
       - name: Generate Attributions
         run: yarn attributions:generate
       - name: Cache attributions file

diff --git a/.github/workflows/update-lavamoat-policies.yml b/.github/workflows/update-lavamoat-policies.yml
@@ -61,7 +61,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
       - name: Get commit SHA
         id: commit-sha
         run: echo "COMMIT_SHA=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT"
@@ -82,7 +82,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
       - name: Update LavaMoat build policy
         run: yarn lavamoat:build:auto
       - name: Cache build policy
@@ -113,7 +113,7 @@ jobs:
       - name: Setup environment
         uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
-          should-cache-restore: $USE_CACHING
+          should-cache-restore: ${{ env.USE_CACHING }}
       - name: Restore build policy
         uses: actions/cache/restore@v4
         with: