Fix #20930 - Prevent Firefox start failure by awaiting startUISync ev…

…ent (#20992) * Fix #20930 - Prevent Firefox start failure by awaiting startUISync event * Update documentation
MetaMask · Sep 21, 2023 · 48184fe · 48184fe
1 parent 31262a0
commit 48184fe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
@@ -3211,7 +3211,7 @@ export default class MetamaskController extends EventEmitter {
   }
 
   _startUISync() {
-    // Message startUISync is used in MV3 to start syncing state with UI
+    // Message startUISync is used to start syncing state with UI
     // Sending this message after login is completed helps to ensure that incomplete state without
     // account details are not flushed to UI.
     this.emit('startUISync');

diff --git a/app/scripts/ui.js b/app/scripts/ui.js
@@ -257,7 +257,13 @@ async function start() {
     extensionPort.onMessage.addListener(messageListener);
     extensionPort.onDisconnect.addListener(resetExtensionStreamAndListeners);
   } else {
-    initializeUiWithTab(activeTab);
+    const messageListener = async (message) => {
+      if (message?.data?.method === 'startUISync') {
+        initializeUiWithTab(activeTab);
+        extensionPort.onMessage.removeListener(messageListener);
+      }
+    };
+    extensionPort.onMessage.addListener(messageListener);
   }
 
   function initializeUiWithTab(tab) {