Skip to content

Commit

Permalink
feat: added solana to flask build (#29147)
Browse files Browse the repository at this point in the history
## **Description**

Added Solana feature on Flask build

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29195?quickstart=1)

## **Related issues**

N/A

## **Manual testing steps**

- Open Experimental settings and enable Solana
- You should see Solana option when creating account

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Charly Chevalier <[email protected]>
  • Loading branch information
javiergarciavera and ccharly authored Dec 16, 2024
1 parent fb0b414 commit 45c7bfd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ buildTypes:
features:
- build-flask
- keyring-snaps
- solana
env:
- INFURA_FLASK_PROJECT_ID
- SEGMENT_FLASK_WRITE_KEY
Expand Down
7 changes: 4 additions & 3 deletions privacy-snapshot.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,18 @@
"on-ramp-content.uat-api.cx.metamask.io",
"phishing-detection.api.cx.metamask.io",
"portfolio.metamask.io",
"price-api.metamask-institutional.io",
"price.api.cx.metamask.io",
"proxy.api.cx.metamask.io",
"proxy.dev-api.cx.metamask.io",
"signature-insights.api.cx.metamask.io",
"raw.githubusercontent.com",
"registry.npmjs.org",
"responsive-rpc.test",
"security-alerts.api.cx.metamask.io",
"security-alerts.dev-api.cx.metamask.io",
"sentry.io",
"sepolia.infura.io",
"signature-insights.api.cx.metamask.io",
"snaps.metamask.io",
"sourcify.dev",
"start.metamask.io",
Expand All @@ -72,6 +73,6 @@
"unresponsive-rpc.test",
"unresponsive-rpc.url",
"user-storage.api.cx.metamask.io",
"www.4byte.directory",
"verify.walletconnect.com"
"verify.walletconnect.com",
"www.4byte.directory"
]

0 comments on commit 45c7bfd

Please sign in to comment.