Skip to content

Commit

Permalink
test: fix flaky erc20 send token e2e (#28775)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The issue is that sometimes when clicking on the watchAssets button from
the test dapp the metamask dialog does not open. The test dapp button is
present and enabled but for some reason clicking on it does nothing.
However if you wait for a second and then click this seems to solve the
issue.

Also tried to wait until the page is loaded, element is present, visible
and enabled, however, the flakiness persists. Hence added a hardcoded
wait.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28775?quickstart=1)

## **Related issues**

Fixes:
[#28700](#28700)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: Harika <[email protected]>
  • Loading branch information
pnarayanaswamy and hjetpoluru authored Dec 5, 2024
1 parent 27f3c21 commit 456e63f
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ async function createWalletInitiatedTransactionAndAssertDetails(

await testDapp.openTestDappPage({ contractAddress, url: DAPP_URL });

await driver.delay(1000);
await testDapp.clickERC20WatchAssetButton();

await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog);
Expand Down Expand Up @@ -172,6 +173,7 @@ async function createDAppInitiatedTransactionAndAssertDetails(

await testDapp.openTestDappPage({ contractAddress, url: DAPP_URL });

await driver.delay(1000);
await testDapp.clickERC20WatchAssetButton();

await driver.delay(veryLargeDelayMs);
Expand Down

0 comments on commit 456e63f

Please sign in to comment.